Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:18648
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <6.2.3.4.2.20050901215122.03dd58c0@localhost>
Date: Thu, 01 Sep 2005 21:52:24 -0700
To: Markus Fischer <markus@fischer.name>
Cc: John Coggeshall <john@coggeshall.org>,internals@lists.php.net,
	iliaa@php.net
In-Reply-To: <431602E7.5050500@fischer.name>
References: <42D78B4A.7080208@fischer.name>
	<42D78B4A.7080208@fischer.name>
	<5.1.0.14.2.20050715120049.02739670@localhost>
	<431602E7.5050500@fischer.name>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Subject: Re: [PHP-DEV] [Patch] tidy node and getParent
From: andi@zend.com (Andi Gutmans)

Hey Markus,

As we're waiting for Wez to commit fixes, and this patch is just 
adding a new function (and not messing with existing functionality), 
I think it's OK to include...
We'll have to roll RC2.
Rasmus, Wez - Any idea about timing for PDO? Are all these bugs 
crucial to fix for 5.1?

Andi

At 12:20 PM 8/31/2005, Markus Fischer wrote:
>Hi,
>
>can this be taken into consideration for HEAD now that RC1 is out of the door?
>
>thanks,
>- Markus
>
>Andi Gutmans wrote:
>>We're in a feature freeze so please hold it to after 5.1.0 is out 
>>the door. You'll be able to commit to head when RC1 is branched off.
>>Thanks,
>>Andi
>>At 01:31 PM 7/15/2005 -0400, John Coggeshall wrote:
>>
>>>I'll take a look at it and commit if it looks good.
>>>
>>>John
>>>
>>>On Fri, 2005-07-15 at 12:09 +0200, Markus Fischer wrote:
>>> > Hi,
>>> >
>>> > attached is a patch to add the getParent() method for the tidyNode
>>> > against HEAD.
>>> >
>>> > It's just a quick patch for me. I don't know if all tidy version support
>>> > the getTidyParent function and if it's memory leak free so someone
>>> > should review it first.
>>> >
>>> > cheers,
>>> > - Markus
>>> > plain text document attachment (tidy_getParent.diff.txt)
>>> > ? tidy_getParent.diff.txt
>>> > Index: php_tidy.h
>>> > ===================================================================
>>> > RCS file: /repository/php-src/ext/tidy/php_tidy.h,v
>>> > retrieving revision 1.25
>>> > diff -u -r1.25 php_tidy.h
>>> > --- php_tidy.h        25 Apr 2005 20:46:16 -0000      1.25
>>> > +++ php_tidy.h        15 Jul 2005 09:59:44 -0000
>>> > @@ -89,6 +89,7 @@
>>> >  TIDY_NODE_METHOD(isJste);
>>> >  TIDY_NODE_METHOD(isAsp);
>>> >  TIDY_NODE_METHOD(isPhp);
>>> > +TIDY_NODE_METHOD(getParent);
>>> >
>>> >  ZEND_BEGIN_MODULE_GLOBALS(tidy)
>>> >       char *default_config;
>>> > Index: tidy.c
>>> > ===================================================================
>>> > RCS file: /repository/php-src/ext/tidy/tidy.c,v
>>> > retrieving revision 1.65
>>> > diff -u -r1.65 tidy.c
>>> > --- tidy.c    25 Apr 2005 20:46:16 -0000      1.65
>>> > +++ tidy.c    15 Jul 2005 09:59:45 -0000
>>> > @@ -291,6 +291,7 @@
>>> >       TIDY_NODE_ME(isJste, NULL)
>>> >       TIDY_NODE_ME(isAsp, NULL)
>>> >       TIDY_NODE_ME(isPhp, NULL)
>>> > +     TIDY_NODE_ME(getParent, NULL)
>>> >       {NULL, NULL, NULL}
>>> >  };
>>> >
>>> > @@ -1668,6 +1669,30 @@
>>> >  }
>>> >  /* }}} */
>>> >
>>> > +/* {{{ proto boolean tidyNode::getParent()
>>> > +   Returns the parent node if available or NULL */
>>> > +TIDY_NODE_METHOD(getParent)
>>> > +{
>>> > +     TidyNode        parent_node;
>>> > +     PHPTidyObj *newobj;
>>> > +     TIDY_FETCH_ONLY_OBJECT;
>>> > +
>>> > +     parent_node = tidyGetParent(obj->node);
>>> > +     if(parent_node) {
>>> > +             tidy_instanciate(tidy_ce_node, return_value TSRMLS_CC);
>>> > +             newobj = (PHPTidyObj *) 
>>> zend_object_store_get_object(return_value TSRMLS_CC);
>>> > +             newobj->node = parent_node;
>>> > +             newobj->type = is_node;
>>> > +             newobj->ptdoc = obj->ptdoc;
>>> > +             newobj->ptdoc->ref_count++;
>>> > +             tidy_add_default_properties(newobj, is_node TSRMLS_CC);
>>> > +     } else {
>>> > +             ZVAL_NULL(return_value);
>>> > +     }
>>> > +}
>>> > +/* }}} */
>>> > +
>>> > +
>>> >  static void _php_tidy_register_nodetypes(INIT_FUNC_ARGS)
>>> >  {
>>> >       TIDY_NODE_CONST(ROOT, Root);
>>> >
>>> > --
>>> > PHP Internals - PHP Runtime Development Mailing List
>>> > To unsubscribe, visit: http://www.php.net/unsub.php
>>>
>>>--
>>>PHP Internals - PHP Runtime Development Mailing List
>>>To unsubscribe, visit: http://www.php.net/unsub.php
>>