Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:18608 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 44304 invoked by uid 1010); 31 Aug 2005 14:44:48 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 44289 invoked from network); 31 Aug 2005 14:44:48 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Aug 2005 14:44:48 -0000 X-Host-Fingerprint: 69.12.155.130 69-12-155-130.dsl.static.sonic.net Linux 2.4/2.6 Received: from ([69.12.155.130:3702] helo=pigeon.alphaweb.net) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 17/05-15098-062C5134 for ; Wed, 31 Aug 2005 10:44:48 -0400 Received: from localhost ([127.0.0.1] helo=lighthammer) by pigeon.alphaweb.net with smtp (Exim 4.10) id 1EATBl-0001H8-00; Wed, 31 Aug 2005 07:03:41 -0700 Message-ID: <00b401c5ae3a$86ca0590$6c051fac@lighthammer> To: "Zeev Suraski" Cc: References: <5.1.0.14.2.20050830050232.05ed1ec0@localhost> Date: Wed, 31 Aug 2005 07:44:23 -0700 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2180 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180 Subject: Re: PHP 5.1 From: pollita@php.net ("Sara Golemon") > For those of you who submitted patches to 5.1 since RC1 - do you believe > that we need another RC or can we go ahead and roll 5.1 final and run a > sanity test for 24 hours? I went over the patches, none of them appears > to be too dangerous, but if any of you thinks differently, let me know. > Never got a clear response on whether or not that zend_shutdown_constants(TSRMLS_C);/zend_destroy_rsrc_list(&EG(persistent_list) TSRMLS_CC); patch (ZTS leak thread) could be committed. I realized I might've been misleading when I said I'd "temporarily plugged that leak" I meant in my own local checkout, not in CVS. As it's a general bug I'd like to spread it across stable branches 4.4/5.0 and dev branches 5.1/HEAD (with proper timing given RC cycles of course). Index: Zend/zend.c =================================================================== RCS file: /repository/ZendEngine2/zend.c,v retrieving revision 1.308 diff -u -r1.308 zend.c --- Zend/zend.c 3 Aug 2005 13:30:45 -0000 1.308 +++ Zend/zend.c 31 Aug 2005 14:39:28 -0000 @@ -486,6 +486,8 @@ static void executor_globals_dtor(zend_executor_globals *executor_globals TSRMLS_DC) { zend_ini_shutdown(TSRMLS_C); + zend_shutdown_constants(TSRMLS_C); + zend_destroy_rsrc_list(&EG(persistent_list) TSRMLS_CC); } @@ -706,11 +708,9 @@ zend_shutdown_extensions(TSRMLS_C); free(zend_version_info); - zend_shutdown_constants(TSRMLS_C); free(GLOBAL_FUNCTION_TABLE); free(GLOBAL_CLASS_TABLE); #ifdef ZTS - zend_destroy_rsrc_list(&EG(persistent_list) TSRMLS_CC); zend_hash_destroy(GLOBAL_CONSTANTS_TABLE); free(GLOBAL_CONSTANTS_TABLE); GLOBAL_FUNCTION_TABLE = NULL;