Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:18547 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 28720 invoked by uid 1010); 30 Aug 2005 05:20:42 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 28705 invoked from network); 30 Aug 2005 05:20:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Aug 2005 05:20:42 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:33596] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 6D/68-15098-8ACE3134 for ; Tue, 30 Aug 2005 01:20:41 -0400 Received: (qmail 31936 invoked from network); 30 Aug 2005 05:20:36 -0000 Received: from localhost (HELO ANDI-NOTEBOOK.zend.com) (127.0.0.1) by localhost with SMTP; 30 Aug 2005 05:20:36 -0000 Message-ID: <6.2.3.4.2.20050829221937.039c5eb0@localhost> X-Mailer: QUALCOMM Windows Eudora Version 6.2.3.4 Date: Mon, 29 Aug 2005 22:20:49 -0700 To: Johannes Schlueter ,internals@lists.php.net In-Reply-To: <200508271434.50578.johannes@php.net> References: <200508271434.50578.johannes@php.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [patch] extending internal functions with module information From: andi@zend.com (Andi Gutmans) Hi Johannes, I think this patch is useful and I see no reason not to include it. Due to API breakage I suggest we only put this into HEAD. Andi At 05:34 AM 8/27/2005, Johannes Schlueter wrote: >Hi Andi et al., > >the attached patch adds the module registering an internal function to the >zend_internal_function structure. This information can be (and is by this >patch) used by the reflection API - currently it's quite hard to get the >extension defining a function. I additionally used this information to make a >more verbose error messages when redefining an internal function. > >Please take a look at it and commit at will. > >johannes > >p.s. If the patch doesn't reach the list it's available at >http://svn.schlueters.de/phpatches/HEAD/zend_function_module.diff, too. > >p.p.s. In Steph's PAT directory is my ReflectionProptery::getLinenumber() >patch still waiting, too ;-) http://www.zend.com/zend/week/pat/pat26.txt >