Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:18545 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 18722 invoked by uid 1010); 30 Aug 2005 04:42:02 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 18707 invoked from network); 30 Aug 2005 04:42:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Aug 2005 04:42:02 -0000 X-Host-Fingerprint: 69.12.155.130 69-12-155-130.dsl.static.sonic.net Linux 2.4/2.6 Received: from ([69.12.155.130:2566] helo=pigeon.alphaweb.net) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 37/C7-15098-A93E3134 for ; Tue, 30 Aug 2005 00:42:02 -0400 Received: from localhost ([127.0.0.1] helo=lighthammer) by pigeon.alphaweb.net with smtp (Exim 4.10) id 1E9xJ3-0006N9-00; Mon, 29 Aug 2005 21:01:05 -0700 Message-ID: <001601c5ad1d$295a5590$6c051fac@lighthammer> To: "Zeev Suraski" Cc: References: <011d01c5ace6$de33a7f0$5c8be5a9@ohr.berkeley.edu> <5.1.0.14.2.20050830031409.045fe2e0@localhost> Date: Mon, 29 Aug 2005 21:40:48 -0700 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2180 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180 Subject: Re: [PHP-DEV] ZTS leak From: pollita@php.net ("Sara Golemon") >>@@ -706,7 +707,6 @@ >> zend_shutdown_extensions(TSRMLS_C); >> free(zend_version_info); >> >>- zend_shutdown_constants(TSRMLS_C); >> free(GLOBAL_FUNCTION_TABLE); >> free(GLOBAL_CLASS_TABLE); >> #ifdef ZTS > > Are you sure it's not leaking the global constants table with the > zend_shutdown_constants() removed from zend_shutdown()? > Incidently, I just opened my terminal back up and noticed the next three lines immediately following the code block above are: zend_destroy_rsrc_list(&EG(persistent_list) TSRMLS_CC); zend_hash_destroy(GLOBAL_CONSTANTS_TABLE); free(GLOBAL_CONSTANTS_TABLE); Which is of course why there's no leak when zend_shutdown_constants(TSRMLS_C); is moved out of zend_shutdown().