Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:18504
Return-Path: <D.Kingma@jool.nl>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 57674 invoked by uid 1010); 28 Aug 2005 08:15:25 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 57658 invoked from network); 28 Aug 2005 08:15:25 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 28 Aug 2005 08:15:25 -0000
Received: from ([127.0.0.1:25634])
	by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with ECSTREAM
	id AF/5C-28235-C9271134 for <internals@lists.php.net>; Sun, 28 Aug 2005 04:15:25 -0400
X-Host-Fingerprint: 195.121.6.27 smtp13.wxs.nl NetCache Data OnTap 5.x
Received: from ([195.121.6.27:32964] helo=smtp13.wxs.nl)
	by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP
	id BB/2C-28235-83271134 for <internals@lists.php.net>; Sun, 28 Aug 2005 04:13:45 -0400
Received: from [10.0.0.150] ([84.87.180.211])
	by smtp13.wxs.nl (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004))
	with ESMTP id <0ILX00DAYAUUXQ@smtp13.wxs.nl> for internals@lists.php.net; Sun,
	28 Aug 2005 10:13:42 +0200 (CEST)
Date: Sun, 28 Aug 2005 10:18:57 +0200
In-reply-to: <200508280159.28079.johannes@php.net>
To: Johannes Schlueter <johannes@php.net>
Cc: internals@lists.php.net, Sara Golemon <pollita@php.net>
Message-ID: <43117371.7060301@jool.nl>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7BIT
X-Accept-Language: en-us, en
User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
References: <42FCE0E4.604@lerdorf.com> <4310BBD1.3030408@prohost.org>
	<005101c5ab53$1d977e70$6c051fac@lighthammer>
	<200508280159.28079.johannes@php.net>
Subject: Re: [PHP-DEV] PHP 6.0 Wishlist
From: D.Kingma@jool.nl ("David Kingma | jool.nl")

Johannes Schlueter wrote:

>Hi Sara,
>
>On Sunday 28 August 2005 00:02, Sara Golemon wrote:
>  
>
>>+<INITIAL>"<?xml"([ \t]|{NEWLINE}) {
>>    
>>
>
>And what's with <?xml-stylesheet ?> or any other processing instruction? Even 
>so others than xml are rarely used it would imho be a great wtf factor if 
><?xml is somehow special.
>
>At a sidenote: If you output xml you anyways neet to set the right 
>content-type header, so either set default_mimetype to text/xml (or similar) 
>and turn of short_open_tags in the php.ini or start the file with a header() 
>call followed by an echo of the xml-pi.
>  
>
If you replace the te following lines:

<INITIAL>"<?"|"<script"{WHITESPACE}+"language"{WHITESPACE}*"="{WHITESPACE}*("php"|"\"php\""|"\'php\'"){WHITESPACE}*">" {
	HANDLE_NEWLINES(yytext, yyleng);
	if (CG(short_tags) || yyleng>2) { /* yyleng>2 means it's not <? but <script> */


with:

<INITIAL>"<? "|"<script"{WHITESPACE}+"language"{WHITESPACE}*"="{WHITESPACE}*("php"|"\"php\""|"\'php\'"){WHITESPACE}*">" {
	HANDLE_NEWLINES(yytext, yyleng);
	if (CG(short_tags) || yyleng>3) { /* yyleng>3 means it's not <? but <script> */


(notice the space behind '?' and the length check from 2 to 3) Wouldn't 
that fix the whole problem without creating a special case for <?xml ?

David