Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:18331
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <013f01c5a845$5d4ffc60$5c8be5a9@ohr.berkeley.edu>
Reply-To: "Sara Golemon" <pollita@php.net>
To: <internals@lists.php.net>
Cc: "Andi Gutmans" <andi@zend.com>
References: <004501c5a813$1691dc30$5c8be5a9@ohr.berkeley.edu> <6.2.3.4.2.20050823161755.03bffe20@localhost> <010901c5a83f$7eb7ade0$5c8be5a9@ohr.berkeley.edu>
Date: Tue, 23 Aug 2005 17:47:11 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Returning References from Internal Functions
From: pollita@php.net ("Sara Golemon")

> There's some commented out code in there that refers to bug 34045:
> /*  We shouldn't fix bad extensions here,
>     because it can break proper ones (Bug #34045)
>         if (!EX(function_state).function->common.return_reference) {
>             EX_T(opline->result.u.var).var.ptr->is_ref = 0;
>             EX_T(opline->result.u.var).var.ptr->refcount = 1;
>         }
> */
>
> With that code in there returning references would certainly never work so
> I'd be curious about the events leading up to that removal as much as
> anything.
>
Doi... Ignore that particular comment.  All that code does is block
reference passing when the arg info isn't set.  (Which would seem perfectly
reasonable...)

The rest of it still stands, I just spent too long unfolding engine code
today decoding the fcall_returned_reference logic... :)

-Sara