Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:17748
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
	s=beta; d=gmail.com;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=M848PSjD3sl2Jtc2xnUctG2UOUZhQvc84F3Dx2M8lo7zPsJjqnwjHMcsgpbQSxVApw0mn3sgwgvmO3nFNMxfLmrz6Iy3Sgsea3omqtBoCUmCsCYGwvG2FJtmy6bZVQTjP8FslYQ4TZ2+70rYaMOPNQpKCkB6cstObqXc/yXrcGw=
Message-ID: <4e89b42605080914013d07d760@mail.gmail.com>
Date: Tue, 9 Aug 2005 17:01:56 -0400
To: Marcus Boerger <helly@php.net>
Cc: Nuno Lopes <nlopess@php.net>, John Coggeshall <john@coggeshall.org>, 
	internals@lists.php.net
In-Reply-To: <1585648665.20050809225855@marcus-boerger.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <1123619893.8518.7.camel@localhost.localdomain>
	<002001c59d23$c697f1f0$0100a8c0@pc07653>
	<4e89b42605080913557fca085f@mail.gmail.com>
	<1585648665.20050809225855@marcus-boerger.de>
Subject: Re: [PHP-DEV] GCOV
From: kingwez@gmail.com (Wez Furlong)

No, I'm not (both not the only one using an older version, nor am I
necessarily using an older version).

Until someone points out a re2c bug that actually impacts PHP, I'm in
no rush to run around upgrading more than 20 machines.

--Wez.

On 8/9/05, Marcus Boerger <helly@php.net> wrote:
> Hello Wez,
>=20
>   just to remind you: you are the only one using an old unsupport version
> that doesn't come with -o.
>=20
> marcus
>=20
> Tuesday, August 9, 2005, 10:55:43 PM, you wrote:
>=20
> > JFYI: -o doesn't work on all versions of re2c
>=20
> > --Wez.
>=20
> > On 8/9/05, Nuno Lopes <nlopess@php.net> wrote:
> >> Hi,
> >>
> >> I've already had a change to test your patch (I've even have asked my
> >> university for a server to put ithe reports on-line).
> >> I've also came into this issue, which happens because re2c is called i=
n the
> >> wrong way (the output is printed to stdout, rather than directly to th=
e
> >> file). Those files should be generated with 're2c -b -o output_file.c
> >> in_file.re'. (also: re2c should be called from the directory where the
> >> in_file.re is, so that it uses relatives paths)
> >> Conclusion, you just need to regenerate the parsers correctly.
> >>
> >> BTW, there was an error in your patch: it cleans the *.gcno files (whi=
ch are
> >> generated at compile time) in cov_gen_clean() before running lcov, thu=
s
> >> breaking the proccess.
> >>
> >>
> >> Nuno
> >>
> >>
> >> ----- Original Message -----
> >> From: "John Coggeshall" <john@coggeshall.org>
> >> To: <internals@lists.php.net>
> >> Sent: Tuesday, August 09, 2005 9:38 PM
> >> Subject: [PHP-DEV] GCOV
> >>
> >>
> >> > Before we deep-freeze the CVS, I'd like to get my GCOV stuff committ=
ed.
> >> > The changes are relatively minor and I've already run it past Andi. =
I'm
> >> > trying to get around one last problem that maybe someone else can ta=
ke
> >> > care of:
> >> >
> >> > The basic issue is that our parsers have broken file/line preprocess=
or
> >> > directives... since we're pre-generating these files and then commit=
ting
> >> > them, things like #file and #line are breaking gcov because it's usi=
ng
> >> > them to look for source and the paths are from whomever committed th=
em
> >> > to begin with. I spoke with Andi about this at OSCON and we agreed t=
hat
> >> > it's probably best when GCOV is enabled to strip those preprocessor
> >> > directives out beforehand. Any other thoughts/comments? If no one ha=
s a
> >> > better solution I'll commit the code later today.
>=20
>=20
> Best regards,
>  Marcus
>=20
>