Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:17747
Return-Path: <george@omniti.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 93124 invoked by uid 1010); 9 Aug 2005 20:59:49 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 93109 invoked from network); 9 Aug 2005 20:59:49 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 9 Aug 2005 20:59:49 -0000
X-Host-Fingerprint: 66.80.117.3 longsword.omniti.com Linux 2.5 (sometimes 2.4) (4)
Received: from ([66.80.117.3:45905] helo=mail.omniti.com)
	by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP
	id 3E/E1-04646-34919F24 for <internals@lists.php.net>; Tue, 09 Aug 2005 16:59:48 -0400
Authentication-Results: mail.omniti.com smtp.user=george; auth=pass (LOGIN)
DomainKey-Status: good
X-DomainKeys: Ecelerity dk_sign implementing draft-delany-domainkeys-base-01
DomainKey-Signature: q=dns; a=rsa-sha1; c=nofws;
	s=test; d=omniti.com;
	h=Received:In-Reply-To:References:Mime-Version:Content-Type:Message-Id:Cc:From:Subject:Date:To:X-Mailer;
	b=ArxKoxGBASyW+wnHP9xkR4OIEYnfaHnmqg7UhRP8EsEfJnsjoTAouHv7gTk/cJ+f
	oM05rr7qDP22s2GoVTY8Ih7JXnVs27jtZl6CdYgsfZCQBs1sE7JfkOerB4DgeD7r
Received: from ([66.80.117.2:59909] helo=[10.80.116.150])
	by mail.omniti.com (ecelerity 2.0 r(6416M)) with SMTP
	id B1/00-25370-93919F24 for <kingwez@gmail.com>; Tue, 09 Aug 2005 16:59:43 -0400
In-Reply-To: <4e89b42605080913557fca085f@mail.gmail.com>
References: <1123619893.8518.7.camel@localhost.localdomain> <002001c59d23$c697f1f0$0100a8c0@pc07653> <4e89b42605080913557fca085f@mail.gmail.com>
Mime-Version: 1.0 (Apple Message framework v733)
Content-Type: multipart/alternative; boundary=Apple-Mail-18--714915277
Message-ID: <C9A05710-12B4-4B11-B3FF-7F86E0F40DA6@omniti.com>
Cc: George Schlossnagle <george@omniti.com>,
	Nuno Lopes <nlopess@php.net>,
	John Coggeshall <john@coggeshall.org>,
	internals@lists.php.net
Date: Tue, 9 Aug 2005 16:59:32 -0400
To: Wez Furlong <kingwez@gmail.com>
X-Mailer: Apple Mail (2.733)
Subject: Re: [PHP-DEV] GCOV
From: george@omniti.com (George Schlossnagle)

--Apple-Mail-18--714915277
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	delsp=yes;
	format=flowed


On Aug 9, 2005, at 4:55 PM, Wez Furlong wrote:

> JFYI: -o doesn't work on all versions of re2c

Since when has PHP been concerned about not requiring the most-most  
recent version of a library, let alone a development tool?

George <still sore about having to upgrade libxml2 every couple weeks>

>
> --Wez.
>
> On 8/9/05, Nuno Lopes <nlopess@php.net> wrote:
>
>> Hi,
>>
>> I've already had a change to test your patch (I've even have asked my
>> university for a server to put ithe reports on-line).
>> I've also came into this issue, which happens because re2c is  
>> called in the
>> wrong way (the output is printed to stdout, rather than directly  
>> to the
>> file). Those files should be generated with 're2c -b -o output_file.c
>> in_file.re'. (also: re2c should be called from the directory where  
>> the
>> in_file.re is, so that it uses relatives paths)
>> Conclusion, you just need to regenerate the parsers correctly.
>>
>> BTW, there was an error in your patch: it cleans the *.gcno files  
>> (which are
>> generated at compile time) in cov_gen_clean() before running lcov,  
>> thus
>> breaking the proccess.
>>
>>
>> Nuno
>>
>>
>> ----- Original Message -----
>> From: "John Coggeshall" <john@coggeshall.org>
>> To: <internals@lists.php.net>
>> Sent: Tuesday, August 09, 2005 9:38 PM
>> Subject: [PHP-DEV] GCOV
>>
>>
>>
>>> Before we deep-freeze the CVS, I'd like to get my GCOV stuff  
>>> committed.
>>> The changes are relatively minor and I've already run it past  
>>> Andi. I'm
>>> trying to get around one last problem that maybe someone else can  
>>> take
>>> care of:
>>>
>>> The basic issue is that our parsers have broken file/line  
>>> preprocessor
>>> directives... since we're pre-generating these files and then  
>>> committing
>>> them, things like #file and #line are breaking gcov because it's  
>>> using
>>> them to look for source and the paths are from whomever committed  
>>> them
>>> to begin with. I spoke with Andi about this at OSCON and we  
>>> agreed that
>>> it's probably best when GCOV is enabled to strip those preprocessor
>>> directives out beforehand. Any other thoughts/comments? If no one  
>>> has a
>>> better solution I'll commit the code later today.
>>>
>>> John
>>>
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

George Schlossnagle

-- Vice President of Engineering
-- OmniTI Computer Consulting
-- http://www.omniti.com


--Apple-Mail-18--714915277--