Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:17746 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 91969 invoked by uid 1010); 9 Aug 2005 20:58:54 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 91954 invoked from network); 9 Aug 2005 20:58:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Aug 2005 20:58:53 -0000 X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:35680] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 63/B1-04646-D0919F24 for ; Tue, 09 Aug 2005 16:58:53 -0400 Received: from [192.168.1.3] (dsl-082-083-244-228.arcor-ip.net [82.83.244.228]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id 2988535C37B; Tue, 9 Aug 2005 23:17:57 +0200 (CEST) Date: Tue, 9 Aug 2005 22:58:55 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <1585648665.20050809225855@marcus-boerger.de> To: Wez Furlong Cc: Nuno Lopes , John Coggeshall , In-Reply-To: <4e89b42605080913557fca085f@mail.gmail.com> References: <1123619893.8518.7.camel@localhost.localdomain> <002001c59d23$c697f1f0$0100a8c0@pc07653> <4e89b42605080913557fca085f@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] GCOV From: helly@php.net (Marcus Boerger) Hello Wez, just to remind you: you are the only one using an old unsupport version that doesn't come with -o. marcus Tuesday, August 9, 2005, 10:55:43 PM, you wrote: > JFYI: -o doesn't work on all versions of re2c > --Wez. > On 8/9/05, Nuno Lopes wrote: >> Hi, >> >> I've already had a change to test your patch (I've even have asked my >> university for a server to put ithe reports on-line). >> I've also came into this issue, which happens because re2c is called in the >> wrong way (the output is printed to stdout, rather than directly to the >> file). Those files should be generated with 're2c -b -o output_file.c >> in_file.re'. (also: re2c should be called from the directory where the >> in_file.re is, so that it uses relatives paths) >> Conclusion, you just need to regenerate the parsers correctly. >> >> BTW, there was an error in your patch: it cleans the *.gcno files (which are >> generated at compile time) in cov_gen_clean() before running lcov, thus >> breaking the proccess. >> >> >> Nuno >> >> >> ----- Original Message ----- >> From: "John Coggeshall" >> To: >> Sent: Tuesday, August 09, 2005 9:38 PM >> Subject: [PHP-DEV] GCOV >> >> >> > Before we deep-freeze the CVS, I'd like to get my GCOV stuff committed. >> > The changes are relatively minor and I've already run it past Andi. I'm >> > trying to get around one last problem that maybe someone else can take >> > care of: >> > >> > The basic issue is that our parsers have broken file/line preprocessor >> > directives... since we're pre-generating these files and then committing >> > them, things like #file and #line are breaking gcov because it's using >> > them to look for source and the paths are from whomever committed them >> > to begin with. I spoke with Andi about this at OSCON and we agreed that >> > it's probably best when GCOV is enabled to strip those preprocessor >> > directives out beforehand. Any other thoughts/comments? If no one has a >> > better solution I'll commit the code later today. Best regards, Marcus