Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:17745 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89506 invoked by uid 1010); 9 Aug 2005 20:55:46 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 89490 invoked from network); 9 Aug 2005 20:55:46 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Aug 2005 20:55:46 -0000 X-Host-Fingerprint: 64.233.184.202 wproxy.gmail.com Linux 2.4/2.6 Received: from ([64.233.184.202:63881] helo=wproxy.gmail.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 43/41-04646-25819F24 for ; Tue, 09 Aug 2005 16:55:46 -0400 Received: by wproxy.gmail.com with SMTP id i22so1322956wra for ; Tue, 09 Aug 2005 13:55:43 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=YOSLcFqrbGXR2G/xDgGJq/DJutbMZEUz+iyYWYdelyISqtar7AheuoXY3qh4wQN5oP9u2IGfmDqOQU8HgpDJg2198l0jpfinh+CxpINSHS9TSRKhpNU/l+b/EbTvdZ5O9aiq6gUMAW9bN2ThWNtTMemah8ll3xpelNJpakIlQpg= Received: by 10.54.37.64 with SMTP id k64mr5917wrk; Tue, 09 Aug 2005 13:55:43 -0700 (PDT) Received: by 10.54.153.5 with HTTP; Tue, 9 Aug 2005 13:55:43 -0700 (PDT) Message-ID: <4e89b42605080913557fca085f@mail.gmail.com> Date: Tue, 9 Aug 2005 16:55:43 -0400 To: Nuno Lopes Cc: John Coggeshall , internals@lists.php.net In-Reply-To: <002001c59d23$c697f1f0$0100a8c0@pc07653> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <1123619893.8518.7.camel@localhost.localdomain> <002001c59d23$c697f1f0$0100a8c0@pc07653> Subject: Re: [PHP-DEV] GCOV From: kingwez@gmail.com (Wez Furlong) JFYI: -o doesn't work on all versions of re2c --Wez. On 8/9/05, Nuno Lopes wrote: > Hi, >=20 > I've already had a change to test your patch (I've even have asked my > university for a server to put ithe reports on-line). > I've also came into this issue, which happens because re2c is called in t= he > wrong way (the output is printed to stdout, rather than directly to the > file). Those files should be generated with 're2c -b -o output_file.c > in_file.re'. (also: re2c should be called from the directory where the > in_file.re is, so that it uses relatives paths) > Conclusion, you just need to regenerate the parsers correctly. >=20 > BTW, there was an error in your patch: it cleans the *.gcno files (which = are > generated at compile time) in cov_gen_clean() before running lcov, thus > breaking the proccess. >=20 >=20 > Nuno >=20 >=20 > ----- Original Message ----- > From: "John Coggeshall" > To: > Sent: Tuesday, August 09, 2005 9:38 PM > Subject: [PHP-DEV] GCOV >=20 >=20 > > Before we deep-freeze the CVS, I'd like to get my GCOV stuff committed. > > The changes are relatively minor and I've already run it past Andi. I'm > > trying to get around one last problem that maybe someone else can take > > care of: > > > > The basic issue is that our parsers have broken file/line preprocessor > > directives... since we're pre-generating these files and then committin= g > > them, things like #file and #line are breaking gcov because it's using > > them to look for source and the paths are from whomever committed them > > to begin with. I spoke with Andi about this at OSCON and we agreed that > > it's probably best when GCOV is enabled to strip those preprocessor > > directives out beforehand. Any other thoughts/comments? If no one has a > > better solution I'll commit the code later today. > > > > John >=20 > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >=20 >