Newsgroups: php.internals,php.qa
Path: news.php.net
Xref: news.php.net php.internals:17693 php.qa:25732
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <1123588346.25543.240287705@webmail.messagingengine.com>
To: "Derick Rethans" <derick@php.net>
Cc: "PHP Quality Assurance Team Mailing List" <php-qa@lists.php.net>, "PHP
	Developers Mailing List" <internals@lists.php.net>
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
References: <1123587107.23784.240286519@webmail.messagingengine.com>
	<Pine.LNX.4.62.0508091336140.3884@localhost>
In-Reply-To: <Pine.LNX.4.62.0508091336140.3884@localhost>
Date: Tue, 09 Aug 2005 04:52:26 -0700
Subject: Re: [PHP-DEV] ext/calendar - New test scripts
From: nrathna@fastmail.fm ("Rathna N")

thank you for the response.
I will incorporate the feedback and send the updated ones.

Regards,
Rathna.

On Tue, 9 Aug 2005 13:45:06 +0200 (CEST), "Derick Rethans"
<derick@php.net> said:
> On Tue, 9 Aug 2005, Rathna N wrote:
> 
> > Sorry, I forgot to add subject line to the old mail.
> 
> the php-qa@lists.php.net list would be the best list for this subject.
> As for the tests, it would be nice if you could provide a unified diff 
> against CVS's HEAD. That's much easier than have to download a .zip file 
> - we can more easily check the test cases then.
> 
> Some points on the tests:
> - please always use lower case filenames for the tests.
> - as --TEST-- name, please just use the name of the function, such as 
>   "jdtojulian()" (without any other description)
> - try always to cover edge cases in your tests. (For gregorian times, it 
>   makes sense to check what it does around the beginning of the 
>   gregorian calendar for example).
> - prefer var_dump() over print_r().
> - Always use the ISO 8601 format for outputting date (if you're 
>   formatting them yourself). See easter_date.phpt f.e.
> - In easter_date.phpt, you'll have to check way more years - just 
>   testing 3 is not enough.
> - There is no --DESCRIPTION-- field as you used in GregorianToJD.phpt.
> - Always use <?php and not <? in test cases (see JDToJulian.phpt).
> - Please stick to the PEAR coding standards in your tests.
> 
> And thanks for picking this up! But perhaps I can suggest to start with 
> other more used extensions? Most of our string and array functions don't 
> have enough testcases either.
> 
> regards,
> Derick
> 
> -- 
> Derick Rethans
> http://derickrethans.nl | http://ez.no | http://xdebug.org
-- 
  Rathna N
  nrathna@fastmail.fm

-- 
http://www.fastmail.fm - mmm... Fastmail...