Newsgroups: php.internals,php.qa Path: news.php.net Xref: news.php.net php.internals:17692 php.qa:25731 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 23262 invoked by uid 1010); 9 Aug 2005 11:45:13 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 23247 invoked from network); 9 Aug 2005 11:45:13 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Aug 2005 11:45:13 -0000 X-Host-Fingerprint: 82.94.239.5 jdi.jdi-ict.nl Linux 2.5 (sometimes 2.4) (4) Received: from ([82.94.239.5:47438] helo=jdi.jdi-ict.nl) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 08/22-04646-94798F24 for ; Tue, 09 Aug 2005 07:45:13 -0400 Received: from localhost (localhost [127.0.0.1]) by jdi.jdi-ict.nl (8.12.11/8.12.11) with ESMTP id j79BjAjJ015527 for ; Tue, 9 Aug 2005 13:45:10 +0200 Received: from localhost (localhost [127.0.0.1]) by jdi.jdi-ict.nl (8.12.11/8.12.11) with ESMTP id j79Bj6hK015496; Tue, 9 Aug 2005 13:45:07 +0200 Date: Tue, 9 Aug 2005 13:45:06 +0200 (CEST) X-X-Sender: derick@localhost To: Rathna N cc: PHP Quality Assurance Team Mailing List , PHP Developers Mailing List In-Reply-To: <1123587107.23784.240286519@webmail.messagingengine.com> Message-ID: References: <1123587107.23784.240286519@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at jdi-ict.nl Subject: Re: [PHP-DEV] ext/calendar - New test scripts From: derick@php.net (Derick Rethans) On Tue, 9 Aug 2005, Rathna N wrote: > Sorry, I forgot to add subject line to the old mail. the php-qa@lists.php.net list would be the best list for this subject. As for the tests, it would be nice if you could provide a unified diff against CVS's HEAD. That's much easier than have to download a .zip file - we can more easily check the test cases then. Some points on the tests: - please always use lower case filenames for the tests. - as --TEST-- name, please just use the name of the function, such as "jdtojulian()" (without any other description) - try always to cover edge cases in your tests. (For gregorian times, it makes sense to check what it does around the beginning of the gregorian calendar for example). - prefer var_dump() over print_r(). - Always use the ISO 8601 format for outputting date (if you're formatting them yourself). See easter_date.phpt f.e. - In easter_date.phpt, you'll have to check way more years - just testing 3 is not enough. - There is no --DESCRIPTION-- field as you used in GregorianToJD.phpt. - Always use