Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:17636
Return-Path: <rvaughn@pheedo.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 32499 invoked by uid 1010); 8 Aug 2005 22:00:13 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 32484 invoked from network); 8 Aug 2005 22:00:13 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 8 Aug 2005 22:00:13 -0000
X-Host-Fingerprint: 208.151.246.192 208-151-246-192.dq1sn.easystreet.com Linux 2.4/2.6
Received: from ([208.151.246.192:46477] helo=sound-o-mat.com)
	by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP
	id 8E/C4-04646-CE5D7F24 for <internals@lists.php.net>; Mon, 08 Aug 2005 18:00:12 -0400
Received: from localhost (localhost [127.0.0.1])
	by sound-o-mat.com (Postfix) with ESMTP
	id EC62511C4CB; Mon,  8 Aug 2005 15:00:04 -0700 (PDT)
Received: from sound-o-mat.com ([127.0.0.1])
	by localhost (cainan.sound-o-mat.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 24247-02; Mon,  8 Aug 2005 14:59:49 -0700 (PDT)
Received: from [192.168.1.3] (linksys [192.168.1.1])
	by sound-o-mat.com (Postfix) with ESMTP
	id BFC2A11C085; Mon,  8 Aug 2005 14:59:48 -0700 (PDT)
Message-ID: <42F7D5D4.6050507@pheedo.com>
Date: Mon, 08 Aug 2005 14:59:48 -0700
Reply-To: rvaughn@pheedo.com
Organization: Pheedo
User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050317)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Marcus Boerger <helly@php.net>
Cc: internals@lists.php.net, Rob Vaughn <rvaughn@pheedo.com>
References: <42F7AD6C.8020003@pheedo.com> <92393548.20050808221717@marcus-boerger.de>
In-Reply-To: <92393548.20050808221717@marcus-boerger.de>
X-Enigmail-Version: 0.91.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: amavisd-new at sound-o-mat.com
Subject: Re: [PHP-DEV] Improvement to test script 'bug22414'
From: rvaughn@pheedo.com (Rob Vaughn)

Hello,

I didn't write the test, I just added code to check the crc32() values, the
rest is the original code.  What should be used instead of '<?' out of
curiousity?  That's all I've ever used.

Marcus Boerger wrote:
> Hello Rob,
> 
>   just a short comment to everyone writing tests: never use '<?' in tests.
> 
> marcus
> 
> Monday, August 8, 2005, 9:07:24 PM, you wrote:
> 
> 
>>Attached is a universal 'diff' that adds a crc32() check to the 'passthru'
>>test as well as an md5() test.  This will help detect if there's a problem
>>with md5() or crc32() unless both are failing, which indicates a problem with
>>the 'mhash' functionality.
> 
> 
>>Cheers, Rob
> 
> 
> 
> 
> Best regards,
>  Marcus
>