Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:17626 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 62582 invoked by uid 1010); 8 Aug 2005 20:17:19 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 62567 invoked from network); 8 Aug 2005 20:17:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Aug 2005 20:17:19 -0000 X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:42520] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 3B/2B-04646-ECDB7F24 for ; Mon, 08 Aug 2005 16:17:18 -0400 Received: from [192.168.1.3] (dsl-082-083-243-003.arcor-ip.net [82.83.243.3]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id 8556735C379; Mon, 8 Aug 2005 22:36:14 +0200 (CEST) Date: Mon, 8 Aug 2005 22:17:17 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <92393548.20050808221717@marcus-boerger.de> To: Rob Vaughn Cc: internals@lists.php.net In-Reply-To: <42F7AD6C.8020003@pheedo.com> References: <42F7AD6C.8020003@pheedo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Improvement to test script 'bug22414' From: helly@php.net (Marcus Boerger) Hello Rob, just a short comment to everyone writing tests: never use ' Attached is a universal 'diff' that adds a crc32() check to the 'passthru' > test as well as an md5() test. This will help detect if there's a problem > with md5() or crc32() unless both are failing, which indicates a problem with > the 'mhash' functionality. > Cheers, Rob Best regards, Marcus