Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:1750 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 59265 invoked from network); 20 May 2003 01:04:24 -0000 Received: from unknown (HELO lt1.firehawksystems.com) (64.71.143.247) by pb1.pair.com with SMTP; 20 May 2003 01:04:24 -0000 Received: from wireless-laptop.firehawksystems.com (adsl-63-206-171-184.dsl.sktn01.pacbell.net [63.206.171.184]) (authenticated (0 bits)) by lt1.firehawksystems.com (8.11.6p2/8.11.6) with ESMTP id h4K14BA10494 (using TLSv1/SSLv3 with cipher EDH-RSA-DES-CBC3-SHA (168 bits) verified NO); Mon, 19 May 2003 18:04:14 -0700 Date: Mon, 19 May 2003 18:04:10 -0700 To: Sterling Hughes Cc: Jani Taskinen , internals@lists.php.net Message-ID: <20030519180410195933.GyazMail.list@firehawksystems.com> In-Reply-To: <1053387178.789.277.camel@hasele> References: <20030519173123910053.GyazMail.list@firehawksystems.com> <20030519175527499210.GyazMail.list@firehawksystems.com> <1053387178.789.277.camel@hasele> Mime-Version: 1.0 (GMessage framework 0.9.9.9) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Mailer: GyazMail version 0.9.9.9 Subject: Re: [PHP-DEV] [PATCH] include_once/require_once core dump From: list@firehawksystems.com ("Brian J. France") Did you get a warning that foo.php couldn't be included? If not try to include_once a file that doesn't exists. The patch is for PHP_4_3 and not cvs head. Brian On 19 May 2003 19:32:59 -0400, Sterling Hughes wrote: > Your test script works fine for me. > > -Sterling > > On Mon, 2003-05-19 at 20:55, Brian J. France wrote: >> > include_once( "foo.php" ); >> ?> >> >> Since foo.php doesn't exists, zend_open will fail and then try to send a >> warning message using file_handle.filename. Since zend_open failed >> file_handle.filename will still be in its initial state of "file_handle = >> {0}". zend_message_dispatcher is called with file_handle.filename, which >> calls php_message_handler_for_zend, which calls php_strip_url_passwd, >> which >> core dumps because *file_handle.filename is a bad address. >> >> Brian >> >> On Tue, 20 May 2003 03:46:14 +0300 (EEST), Jani Taskinen wrote: >>> >>> Any example code? >>> >>> --Jani >>> >>> >>> On Mon, 19 May 2003, Brian J. France wrote: >>> >>>> Can somebody with karma check in the following patch? >>>> >>>> If zend_open fails for require_once or include_oncde, file_handle is >>>> not defined and can't be used for the error/warning message. >>>> Changed to inc_filename->value.str.val which is what is passed to >>>> zend_open. >>>> >>>> Thanks, >>>> >>>> Brian >>>> >>>> >>> >>> -- >>> <- For Sale! -> >>> >>> > -- > "The computer programmer is a creator of universes for which he > alone is responsible. Universes of virtually unlimited complexity > can be created in the form of computer programs." > - Joseph Weizenbaum > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >