Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:1749 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 54966 invoked from network); 20 May 2003 00:58:43 -0000 Received: from unknown (HELO carmine.bestweb.net) (209.94.102.73) by pb1.pair.com with SMTP; 20 May 2003 00:58:43 -0000 Received: from [192.168.1.102] (ip216-179-71-153.cust.bestweb.net [216.179.71.153]) by carmine.bestweb.net (Postfix) with ESMTP id A908C23018; Mon, 19 May 2003 19:58:40 -0500 (EST) To: "Brian J. France" Cc: Jani Taskinen , internals@lists.php.net In-Reply-To: <20030519175527499210.GyazMail.list@firehawksystems.com> References: <20030519173123910053.GyazMail.list@firehawksystems.com> <20030519175527499210.GyazMail.list@firehawksystems.com> Content-Type: text/plain Organization: Message-ID: <1053387178.789.277.camel@hasele> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.4 Date: 19 May 2003 19:32:59 -0400 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] include_once/require_once core dump From: sterling@bumblebury.com (Sterling Hughes) Your test script works fine for me. -Sterling On Mon, 2003-05-19 at 20:55, Brian J. France wrote: > include_once( "foo.php" ); > ?> > > Since foo.php doesn't exists, zend_open will fail and then try to send a > warning message using file_handle.filename. Since zend_open failed > file_handle.filename will still be in its initial state of "file_handle = > {0}". zend_message_dispatcher is called with file_handle.filename, which > calls php_message_handler_for_zend, which calls php_strip_url_passwd, which > core dumps because *file_handle.filename is a bad address. > > Brian > > On Tue, 20 May 2003 03:46:14 +0300 (EEST), Jani Taskinen wrote: > > > > Any example code? > > > > --Jani > > > > > > On Mon, 19 May 2003, Brian J. France wrote: > > > >> Can somebody with karma check in the following patch? > >> > >> If zend_open fails for require_once or include_oncde, file_handle is > >> not defined and can't be used for the error/warning message. > >> Changed to inc_filename->value.str.val which is what is passed to zend_open. > >> > >> Thanks, > >> > >> Brian > >> > >> > > > > -- > > <- For Sale! -> > > > > -- "The computer programmer is a creator of universes for which he alone is responsible. Universes of virtually unlimited complexity can be created in the form of computer programs." - Joseph Weizenbaum