Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:17465
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----_=_NextPart_001_01C5944D.6D753B2A"
Date: Fri, 29 Jul 2005 16:54:31 +0200
Message-ID: <0CEAE485BEBFFB488D93F1800C067F53DBA623@MSGEXS1.tf1.groupetf1.fr>
Thread-Topic: [oci8] bug #33915 (segfault in _oci_close_session) with fix
Thread-Index: AcWUTW0F/BsMr3B+RHeEr6xwgqjIIg==
To: <internals@lists.php.net>
Subject: [oci8] bug #33915 (segfault in _oci_close_session) with fix
From: JFBUSTARRET@tf1.fr ("BUSTARRET, Jean-Francois")

------_=_NextPart_001_01C5944D.6D753B2A
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable


I have quite a few segfaults on my production servers.
=0D
The crashes occur on :
=0D
#0  0xb78f3779 in _oci_close_session (session=3D0x8382a20)
    at /soft/sources/php/php-5.0.4/ext/oci8/oci8.c:2961
2961                    CALL_OCI_RETURN(OCI(error),
where
(gdb) print *session
$1 =3D {num =3D 137800016, persistent =3D 0 '\0', is_open =3D 253 '=FD',
  exclusive =3D 49 '1', thread =3D 8 '\b', sessions_list =3D 0x0, server =
=3D 0x0,
  pSession =3D 0x0, pEnv =3D 0x0, charsetId =3D 0}

At the same time, I have :
[29-Jul-2005 07:57:41] PHP Warning:  Unknown: _oci_close_session=
 OCIHandleAlloc OCI_HTYPE_SVCCTX: OCI_INVALID_HANDLE in Unknown on line 0

I use my oci8 ping_freq patch=
 (http://www.jeuxdecartes.net/static/oci8.ping_freq.patch) - that explains=
 the line numbering difference.
=0D
(more info on http://bugs.php.net/bug.php?id=3D33915)

This small fix corrects the crash (there could be a problem somewhere else=
 - why do I have a session without a server ?) :
=0D
--- php-5.0.4/ext/oci8/oci8.c   2005-07-29 08:13:21.829128377 +0200
+++ php-5.0.4-orig/ext/oci8.fromcvs/oci8.c        2005-07-15=
 14:56:42.000000000 +0200
@@ -2939,10 +2924,6 @@
                return;
        }
=0D
+       /* JFBustarret - fix for bug #33915 */
+       if (!session->server) {
+               return;
+       }
+
        oci_debug("START _oci_close_session: logging-off sess=
=3D%d",session->num);
=0D
        if (session->is_open) {

I updated my ping_freq patch with the fix at :
http://www.jeuxdecartes.net/static/oci8.ping_freq.new.patch

Jean-Fran=E7ois Bustarret
eTF1 - Architecte=0D

=0D


-------------------------------------
Le present message (y compris tous les elements attaches) est confidentiel=
 et est destine a ses seuls destinataires. Si vous
l'avez recu par erreur, merci de l'indiquer a son expediteur par retour et=
 de proceder a sa destruction dans vos systemes.=0D
Toute utilisation ou diffusion non autorisee de son contenu, en totalite ou=
 en partie, est strictement interdite. Les idees et=0D
opinions presentees dans ce message sont celles de son auteur, et ne=
 representent pas necessairement celles de TF1 (et/ou des=0D
entites membres du Groupe TF1).

This message (including any attachments) is confidential and may be=
 privileged. If you have received it by mistake please notify=0D
the sender by return email and delete this message from your system. Any=
 unauthorised use or dissemination of this message in=0D
whole or in part is strictly prohibited. Any views or opinions presented=
 are solely those of its author and do not necessarily=0D
represent those of TF1 (and/or its group companies).
------_=_NextPart_001_01C5944D.6D753B2A--