Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:17385
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <42E11771.1070002@php.net>
Date: Fri, 22 Jul 2005 09:57:37 -0600
User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
MIME-Version: 1.0
To: Wez Furlong <kingwez@gmail.com>
CC: internals@lists.php.net
References: <46.D7.33635.72170E24@pb1.pair.com> <4e89b4260507220536439a0eb0@mail.gmail.com>
In-Reply-To: <4e89b4260507220536439a0eb0@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] new bug in 5.1.0b3 with length param in fread() with
	local files
From: cellog@php.net (Greg Beaver)

Wez Furlong wrote:
> If you've spotted a behaviour change, open a new bug with a short
> self-contained reproducing script.  I suspect some kind of engine bug
> here, because what you've described doesn't make sense :)
> 
> That warning about the length comes from this code in the fread function:
> 
>     len = Z_LVAL_PP(arg2);
>     if (len <= 0) {
>         php_error_docref(NULL TSRMLS_CC, E_WARNING, "Length parameter
> must be greater than 0");
>         RETURN_FALSE;
>     }
> 
> So either you are passing in something that evaluates as 0 (or less),
> or something is corrupting memory and breaking the length value by the
> time it reaches fread().

In the attempt to find a short reproducing test script, I determined 
that the warning was caused by an earlier iteration through the method 
that uses fread.  So, the warning was valid (0 was being passed in). 
What this means, however, is that the script is in fact simply failing 
to read in the requested amount with no warning at all.  I'll have a 
test script shortly for the bug report.

Greg