Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:17310 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 37746 invoked by uid 1010); 18 Jul 2005 08:20:33 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 37729 invoked from network); 18 Jul 2005 08:20:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Jul 2005 08:20:33 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:41351] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.0 beta r(6227M)) with SMTP id 86/08-61486-0566BD24 for ; Mon, 18 Jul 2005 04:20:33 -0400 Received: (qmail 9106 invoked from network); 18 Jul 2005 08:20:28 -0000 Received: from internal.zend.office (HELO hp.home) (10.1.1.1) by internal.zend.office with SMTP; 18 Jul 2005 08:20:28 -0000 Date: Mon, 18 Jul 2005 12:20:27 +0400 To: "BUSTARRET, Jean-Francois" Cc: internals@lists.php.net Message-ID: <20050718122027.20bd21e8.antony@zend.com> In-Reply-To: <0CEAE485BEBFFB488D93F1800C067F53DBA5C5@MSGEXS1.tf1.groupetf1.fr> References: <0CEAE485BEBFFB488D93F1800C067F53DBA5C5@MSGEXS1.tf1.groupetf1.fr> X-Mailer: Sylpheed version 2.0.0beta6 (GTK+ 2.6.4; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [OCI8] Patch for bug #29779 From: antony@zend.com (Antony Dovgal) Hello Jean-Francois! On Mon, 18 Jul 2005 10:08:10 +0200 "BUSTARRET, Jean-Francois" wrote: > > I created a patch for http://bugs.php.net/bug.php?id=29779 (which can be considered as a feature request more than a bug). > > Rather than pinging existing connection each time, which would slow down things too much for high traffic sites, the patch pings connections only every x seconds. Considering this problem occurs when a firewall drops idle connections after let's say one hour of inactivity, I think this is a fine solution. > > I added a php.ini variable : oci8.ping_freq (if not set, oci8 works like before). The code adds a last_ping timestamp to the server struct, and pings when ping_freq > 0 && (time(NULL) - last_ping) > ping_freq. It otherwise uses the commented oci_ping call. > > The patch (against CVS/5.0 branch) can be found at : > http://www.jeuxdecartes.net/static/oci8.ping_freq.patch > > Hope you'll find this patch ok, and will include it in future releases of 5.0. Thanks for the patch. I'm currently working on OCI8 and this issue will be closed along with the others. -- Wbr, Antony Dovgal