Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:1687 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 98866 invoked from network); 19 May 2003 08:37:24 -0000 Received: from unknown (HELO jdi.jdimedia.nl) (212.204.192.51) by pb1.pair.com with SMTP; 19 May 2003 08:37:24 -0000 Received: from jdi.jdimedia.nl (jdi.jdimedia.nl [212.204.192.51]) by jdi.jdimedia.nl (8.12.4/8.12.4) with ESMTP id h4J8bL7A031904; Mon, 19 May 2003 10:37:22 +0200 Date: Mon, 19 May 2003 10:37:21 +0200 (CEST) X-X-Sender: derick@jdi.jdimedia.nl To: Holger Burbach cc: PHP Internals In-Reply-To: <200305161703.40465.holger.burbach@gonicus.de> Message-ID: References: <200305161525.04359.holger.burbach@gonicus.de> <20030516133408.GA11228@lxr> <200305161703.40465.holger.burbach@gonicus.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] PECL Package Proposal: kadm5 - REPOST From: derick@php.net (Derick Rethans) Hey Holger, On Fri, 16 May 2003, Holger Burbach wrote: > > 1. The biggest problem I see is that the extension is throwing E_ERRORs > > which extensions really should not do if they do not leave *PHP* in > > an unstable state (there is also no \n required at the end of the text, > > and in the best case php_error_docref should be used). > > So throwing E_WARNING would be better? Definitely. (After an E_WARNING just return FALSE (or NULL)). > > 2. Check our CODING STANDARDS file again :) > > Okay, I'm working on that. > > > 3. I would recommend to use this naming (As example): > > kadm5_principal_create > > kadm5_principal_modify > > > > instead of: > > kadm5_create_principal > > kadm5_modify_principal > > Sounds reasonable. > > > 4. There are no prototypes for the PHP_FUNCTIONs > > Okay, I'm working on that. > > > 5. There should be atleast one test per function, if possible. > > Hmm, to test the functions I have to connect to an Kerberos V administration > server... Yeah, I know :) But tests also can work as examples so there is something to gain there. The DBX (ext/dbx) guys figured out something clever to handle cases where the DB server was not available, perhaps you can have a look on how they did it. good luck, Derick -- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ International PHP Magazine http://php-mag.net/ -------------------------------------------------------------------------