Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:16350 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 81042 invoked by uid 1010); 31 May 2005 20:35:08 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 66743 invoked from network); 31 May 2005 20:25:48 -0000 Received: from unknown (HELO pb1.pair.com) (127.0.0.1) by localhost with SMTP; 31 May 2005 20:25:48 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:44020] helo=mail.zend.com) by pb1.pair.com (ecelerity 1.2 r(5656M)) with SMTP id A8/00-05850-DCCBC924 for ; Tue, 31 May 2005 15:36:52 -0400 Received: (qmail 7327 invoked from network); 31 May 2005 19:36:28 -0000 Received: from localhost (HELO ANDI-NOTEBOOK.zend.com) (127.0.0.1) by localhost with SMTP; 31 May 2005 19:36:28 -0000 Message-ID: <5.1.0.14.2.20050531111756.039e63a0@localhost> X-Sender: andi@localhost X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Tue, 31 May 2005 12:36:18 -0700 To: Jani Taskinen Cc: internals@lists.php.net In-Reply-To: <5.1.0.14.2.20050531072657.035ad6b0@localhost> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] Re: SID was accidently changed to CONST_CS? From: andi@zend.com (Andi Gutmans) Jani, The flag chance was not intentional. I think I made that change as part of a change to nuke empty_string() and that change to 1 was supposed to tell REGISTER_STRINGL_CONSTANT to dup the string. My mistake and I think it should be reverted. I confused it with the RETURN_* macros. Andi At 07:27 AM 5/31/2005 -0700, Andi Gutmans wrote: >Yes, the flag change was intentional in order to create an allocated empty >string. >I doubt this has anything to do with the bug report though. > >At 11:04 AM 5/31/2005 +0300, Jani Taskinen wrote: > >> Regarding this bug: http://bugs.php.net/bug.php?id=29322&edit=1 >> >> And by looking at this commit by Andi: >> >>http://cvs.php.net/diff.php/php-src/ext/session/session.c?r1=1.391&r2=1.392&ty=u >> >> and this part of it: >> >>- REGISTER_STRINGL_CONSTANT("SID", empty_string, 0, 0); >>+ REGISTER_STRINGL_CONSTANT("SID", "", 0, 1); >> >> Where flags changed from 0 to 1.. >> Intentional or not? >> >> --Jani > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php