Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:16345 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42776 invoked by uid 1010); 31 May 2005 14:51:39 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 26844 invoked from network); 31 May 2005 14:27:58 -0000 Received: from unknown (HELO zend.com) (127.0.0.1) by localhost with SMTP; 31 May 2005 14:27:58 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:55604] helo=mail.zend.com) by pb1.pair.com (ecelerity 1.2 r(5656M)) with SMTP id 4B/EA-09714-0647C924 for ; Tue, 31 May 2005 10:27:51 -0400 Received: (qmail 25341 invoked from network); 31 May 2005 14:27:31 -0000 Received: from localhost (HELO ANDI-NOTEBOOK.zend.com) (127.0.0.1) by localhost with SMTP; 31 May 2005 14:27:31 -0000 Message-ID: <5.1.0.14.2.20050531072657.035ad6b0@localhost> X-Sender: andi@localhost X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Tue, 31 May 2005 07:27:28 -0700 To: Jani Taskinen Cc: internals@lists.php.net In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: SID was accidently changed to CONST_CS? From: andi@zend.com (Andi Gutmans) References: Yes, the flag change was intentional in order to create an allocated empty string. I doubt this has anything to do with the bug report though. At 11:04 AM 5/31/2005 +0300, Jani Taskinen wrote: > Regarding this bug: http://bugs.php.net/bug.php?id=29322&edit=1 > > And by looking at this commit by Andi: > > >http://cvs.php.net/diff.php/php-src/ext/session/session.c?r1=1.391&r2=1.392&ty=u > > and this part of it: > >- REGISTER_STRINGL_CONSTANT("SID", empty_string, 0, 0); >+ REGISTER_STRINGL_CONSTANT("SID", "", 0, 1); > > Where flags changed from 0 to 1.. > Intentional or not? > > --Jani