Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:16178
Return-Path: <sniper@iki.fi>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 48253 invoked by uid 1010); 9 May 2005 13:17:48 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 31847 invoked from network); 9 May 2005 13:05:08 -0000
Received: from unknown (HELO iki.fi) (127.0.0.1)
  by localhost with SMTP; 9 May 2005 13:05:08 -0000
X-Host-Fingerprint: 195.197.172.116 gw02.mail.saunalahti.fi Linux 2.4/2.6
Received: from ([195.197.172.116:49398] helo=gw02.mail.saunalahti.fi)
	by pb1.pair.com (ecelerity 1.2 r(5656M)) with SMTP
	id F1/EA-35155-FFF5F724 for <internals@lists.php.net>; Mon, 09 May 2005 09:05:03 -0400
Received: from nest.netphobia.fi (YZCLXVIII.dsl.saunalahti.fi [85.76.34.69])
	by gw02.mail.saunalahti.fi (Postfix) with ESMTP id 543CFBE19B;
	Mon,  9 May 2005 15:26:15 +0300 (EEST)
Received: from nest.netphobia.fi (nest.netphobia.fi [127.0.0.1])
	by nest.netphobia.fi (8.13.1/8.13.1) with ESMTP id j49CQGZK031668;
	Mon, 9 May 2005 15:26:16 +0300
Received: from localhost (jani@localhost)
	by nest.netphobia.fi (8.13.1/8.13.1/Submit) with ESMTP id j49CQGKG031665;
	Mon, 9 May 2005 15:26:16 +0300
X-Authentication-Warning: nest.netphobia.fi: jani owned process doing -bs
Date: Mon, 9 May 2005 15:26:16 +0300 (EEST)
Reply-To: Jani Taskinen <sniper@iki.fi>
To: Joe Orton <jorton@redhat.com>
Cc: internals@lists.php.net
In-Reply-To: <20050214101606.GA23418@redhat.com>
Message-ID: <Pine.LNX.4.61.0505091524550.24110@arfg.argcubovn.sv>
References: <20050209105920.GA3959@redhat.com> <Pine.LNX.4.61.0502101520480.18425@arfg.argcubovn.sv>
	<20050214101606.GA23418@redhat.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: [PHP-DEV] [PATCH] install ext/gd headers
From: sniper@iki.fi (Jani Taskinen)


     I added PHP_INSTALL_HEADERS() macro in HEAD. And used it
     with gd so now those headers are installed.

     Feel free to backport the patch(es).

     --Jani


On Mon, 14 Feb 2005, Joe Orton wrote:

> On Thu, Feb 10, 2005 at 03:21:45PM +0200, Jani Taskinen wrote:
>>
>>     While this patch works fine, what if you don't actually have
>>     GD installed in your PHP? There should be a configure macro
>>     that adds the headers when really needed..
>
> Good point. OK, how about this instead:
>
> Index: scripts/Makefile.frag
> ===================================================================
> RCS file: /repository/php-src/scripts/Makefile.frag,v
> retrieving revision 1.14
> diff -u -r1.14 Makefile.frag
> --- scripts/Makefile.frag	20 Jan 2005 01:41:20 -0000	1.14
> +++ scripts/Makefile.frag	14 Feb 2005 10:15:31 -0000
> @@ -38,6 +38,7 @@
> 	main/ \
> 	main/streams/ \
> 	regex/ \
> +	$(GD_HEADER_DIRS) \
> 	ext/iconv/ \
> 	ext/libxml/ \
> 	ext/standard/ \
> Index: ext/gd/config.m4
> ===================================================================
> RCS file: /repository/php-src/ext/gd/config.m4,v
> retrieving revision 1.151
> diff -u -r1.151 config.m4
> --- ext/gd/config.m4	4 Jan 2005 06:51:44 -0000	1.151
> +++ ext/gd/config.m4	14 Feb 2005 10:15:31 -0000
> @@ -410,7 +410,9 @@
>   if test "$GD_MODULE_TYPE" = "builtin"; then
>     GDLIB_CFLAGS="-I$ext_srcdir/libgd $GDLIB_CFLAGS"
>     PHP_ADD_BUILD_DIR($ext_builddir/libgd)
> +    GD_HEADER_DIRS="ext/gd/ ext/gd/libgd/"
>   else
> +    GD_HEADER_DIRS="ext/gd/"
>     GDLIB_CFLAGS="-I$GD_INCLUDE $GDLIB_CFLAGS"
>     PHP_ADD_INCLUDE($GD_INCLUDE)
>
> @@ -421,4 +423,5 @@
>
>   PHP_SUBST(GDLIB_CFLAGS)
>   PHP_SUBST(GD_SHARED_LIBADD)
> +  PHP_SUBST(GD_HEADER_DIRS)
> fi
>
>

-- 
Donate @ http://pecl.php.net/wishlist.php/sniper