Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:16048
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <4266894D.1070702@cain.sh>
Date: Wed, 20 Apr 2005 11:54:37 -0500
User-Agent: Mozilla Thunderbird 1.0 (Macintosh/20041206)
MIME-Version: 1.0
To: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [PATCH] Modifications for ext/session/
From: dan@cain.sh ("Daniel J Cain Jr.")

I recently wrote a new custom session handler in PHP5.  In the process 
I've made a couple of changes within ext/session/ that I would like to 
see in the official PHP distribution.

Please consider the following patches for inclusion into PHP.

One change adds a PHP function session_is_started() to determine if a 
session has already been, well... started. :)

It also adds an optional id parameter to session_regenerate_id() 
allowing the user to provide their own id instead of PHP generating a 
new one.  I'm not implying there is anything wrong with PHP generating a 
new id.  I just need session_regenerate_id() to behave like 
session_id($myID), only after a session has already been started.

I've posted the diff output of the affected files at these two locations.

http://www.caincomputing.com/php5/ext/session/session.c.txt
http://www.caincomputing.com/php5/ext/session/php_session.h.txt

This is my first patch submission, so if I've overlooked anything please 
let me know.  Thanks for your time and consideration in advance.

-dan


-- 
D  a  n  i  e  l     J     C  a  i  n     J  r .
                          Zend Certified Engineer 
http://zend.com/zce.php?c=ZEND001685&r=210869656