Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:16034
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Content-Class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 19 Apr 2005 16:02:32 +0100
Message-ID: <08237065FA027340B731E57099097854039A9E23@ukslms22.ca.com>
Thread-Topic: [PATCH] Ingres error reporting functions
Thread-Index: AcVE66QsObbGisBHSGum0JX1gpTBxwAApEXg
To: "Lukas Smith" <lsmith@php.net>
Cc: <internals@lists.php.net>
Subject: RE: [PATCH] Ingres error reporting functions
From: Grant.Croker@ca.com ("Croker, Grant")

Ok,=20

As you say there does not seem to be any consistent naming of functions.
A fact I guess PDO will address. I have changed the names to match mysql
and have a 3rd function (ingres_errsqlstate) that reports the SQLSTATE
of the last statement run. With Ingres SQLSTATE and errno is not the
same thing since errno is more granular than SQLSTATE.

The revised code can be found in this link:

http://www.ingres.co.uk/php/head/ingres_error_reporting_rev2.diff

thanks

grant

> -----Original Message-----
> From: Lukas Smith [mailto:lsmith@php.net]
> Sent: 19 April 2005 16:25
> To: Croker, Grant
> Cc: internals@lists.php.net
> Subject: Re: [PATCH] Ingres error reporting functions
>=20
> Grant Croker wrote:
>=20
> > I would like to submit the following patch to PHP:
> > http://www.ingres.co.uk/php/head/ingres_error_reporting.diff
> >
> > It includes 3 new functions for reporting errors; ingres_error(),
> > ingres_error_text() and ingres_error_sqlstate(). Also included is
the
> > ability to suppress E_WARNING messages that happen when a database
error
> > is detected. This requires the following to be added to php.ini
under
> > the section titled "[Ingres II]":
>=20
> I know its too late to fix this in the current database extensions
(who
> all follow either the native, the mysql ext or some random naming the
> given developer came up with), but you might want to atleast try and
> follow an existing database extension with the function naming. I
guess
> ext/mysql or mysqli might be a good rolemodel just because its used
alot.
>=20
> regards,
> Lukas
>=20