Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:1603 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 51388 invoked by uid 1007); 16 May 2003 18:33:54 -0000 Message-ID: <20030516183354.51387.qmail@pb1.pair.com> To: internals@lists.php.net Reply-To: jay@php.net Mail-Copies-To: jay@php.net Date: Fri, 16 May 2003 14:33:52 -0400 References: <5.2.0.9.0.20030516182813.0292e370@pop3.web.de> <5.2.0.9.0.20030516201801.028ca9e0@pop3.web.de> Lines: 25 User-Agent: KNode/0.7.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit X-Posted-By: 216.94.11.234 Subject: Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) / NEWS From: jay@php.net (Jay Smith) I would have liked to have committed to PHP_4_3, but 4.3.2RC1 had already rolled, and new features shouldn't have been added. Maybe for 4.3.3. I haven't seen the NSAPI problem yet, but I'll try it today. The segfault should be fixed (Ilia, I believe?) in 4_3, I think. J Uwe Schindler wrote: > I think the most important thing is to match for the WHOLE String, so the > pattern must contain ^....$. This is fixed in PHP5 but jay did not want to > put it into 4.3.2 > But adding you code looks pretty good. Longer strings that match are more > accurate. > > And by the way: using the browscap.c from the PHP5 tree at this time does > not lead to the segmentation fault in bug #23657. Compiling with the PHP > 4.3.2RC3 also segfaults on NSAPI. > > Uwe >