Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:1592
Return-Path: <moriyoshi@at.wakwak.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 73246 invoked from network); 16 May 2003 17:36:55 -0000
Received: from unknown (HELO vckyb3.nw.wakwak.com) (211.9.231.144)
  by pb1.pair.com with SMTP; 16 May 2003 17:36:55 -0000
Received: from at.wakwak.com (at.wakwak.com [211.9.230.135:25])
	by vckyb3.nw.wakwak.com (Postfix) with ESMTP
	id 791FE3FE07; Sat, 17 May 2003 02:36:54 +0900 (JST)
Received: from at.wakwak.com (z170.219-121-68.ppp.wakwak.ne.jp [219.121.68.170])
	by at.wakwak.com (8.12.9/8.12.9/2003-03-31) with SMTP id h4GHasH5076159;
	Sat, 17 May 2003 02:36:54 +0900 (JST)
	(envelope-from moriyoshi@at.wakwak.com)
Date: Sat, 17 May 2003 02:39:53 +0900
X-Mailer: EdMax Ver2.85.3F
MIME-Version: 1.0
To: <pollita@php.net>
Cc: internals@lists.php.net
Message-ID: <2003051702395375$K#Z@at.wakwak.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
In-Reply-To: <20030516172617.64238.qmail@pb1.pair.com>
References: <20030516172617.64238.qmail@pb1.pair.com>
Subject: Re: [PHP-DEV] Bug 23654: str_replace doesn't handle multidimensional arrays
From: moriyoshi@at.wakwak.com (Moriyoshi Koizumi)

<pollita@php.net> wrote:

> I've got fixes for str_replace to let it handle multidimensional arrays, but
> I'm not sure if it should be applied to the 4.3 branch or not.  On the one
> hand it changes function behavior so it shouldn't be applied in stable.  On
> the other hand, current behavior is ugly and wrong so it should be fixed..
> 
> Thoughts?

What is your fix like? Actually the current behaviour is ugly, but I don't 
see the idea str_replace() should always be able to handle multi-dim 
arrays as not all the users want it to do so. At most we'd be better off 
if nested arrays were ignored.

Moriyoshi