Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15889
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Thu, 7 Apr 2005 09:28:27 +0300 (EEST)
Reply-To: Jani Taskinen <sniper@iki.fi>
To: "Brian J. France" <list@firehawksystems.com>
Cc: internals@lists.php.net
In-Reply-To: <64fb66853cac5193c88958ffd5f8a6fc@firehawksystems.com>
Message-ID: <Pine.LNX.4.61.0504070926540.785@arfg.argcubovn.sv>
References: <20050327221532.GA17108@csh.rit.edu>
	<Pine.LNX.4.61.0503291106570.29942@arfg.argcubovn.sv> <20050329114511.GB42955@isis.sigpipe.cz>
	<Pine.LNX.4.61.0503291522400.31774@arfg.argcubovn.sv> <20050329124758.GD42955@isis.sigpipe.cz>
	<Pine.LNX.4.61.0503291612160.31876@arfg.argcubovn.sv> <20050330034330.GA6092@csh.rit.edu>
	<20050404053537.GC40@csh.rit.edu> <496e9f86293f5d44da2611a8fce4dc16@firehawksystems.com>
	<64fb66853cac5193c88958ffd5f8a6fc@firehawksystems.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: [PHP-DEV] Build system support for stock FreeBSD autoconf ports
From: sniper@iki.fi (Jani Taskinen)


     I made some changes to phpize now. But not using your
     patch since that would not have worked everywhere.
     Searching for these tools is _still_ a big no no.
     Just make sure they're in PATH.

     --Jani


On Wed, 6 Apr 2005, Brian J. France wrote:

> Ok, lets try this:
>
> http://www.brianfrance.com/patch.build
>
> Brian
>
> On Apr 6, 2005, at 7:19 PM, Brian J. France wrote:
>> On Apr 4, 2005, at 12:35 AM, Jon Parise wrote:
>>> Apologies if this got lost amongst the effort to prepare the recent
>>> set of releases, but I'm curious whether or not people find my second
>>> patch acceptable, based on the results of the prior discussion.  If
>>> not, I'll know to abandon the issue.
>> 
>> Here is a patch that we plan on using at work (Y!). This patch has two key 
>> additions to Jon's patch.  The first I think should be added to Jon's patch 
>> so that shared extensions (phpize) build with his environment variable 
>> change and the second is a change so we don't have to set environment 
>> variables and it will pick up the right files.  The second change may or may 
>> not make it in, but I think the first one should.
>> 
>> The first change is in scripts/phpize.in where it tests and set 
>> PHP_AUTOCONF/PHP_AUTOHEADER variables, then uses them below.  This patch 
>> should be added without the:
>> 
>> +  if ! which $PHP_AUTOCONF; then
>> +      PHP_AUTOCONF=`ls -1 /usr/local/bin/autoconf* | sort -r | head -1`;
>> +      PHP_AUTOHEADER=`ls -1 /usr/local/bin/autoheader* | sort -r | head 
>> -1`;
>> +  fi
>> +
>> 
>> block in it (which would be part of the second change).
>> 
>> The second changes are the ones that do a which command to see if 
>> PHP_AUTOCONF/PHP_AUTOHEADER is really valid and if not try to find the valid 
>> one.  I don't know how compatible this is across os's and is the reason I 
>> can see it not making it (but it works for us).  This package also allows us 
>> to use any version of the ports/autoconf package without having to set 
>> environment variable.
>> 
>> Let me know what you think.
>> 
>> Thanks,
>> 
>> Brian
>> 
>> 
>> 
>> -- 
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php