Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:1566 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 1026 invoked from network); 16 May 2003 13:34:09 -0000 Received: from unknown (HELO lxr) (194.134.214.17) by pb1.pair.com with SMTP; 16 May 2003 13:34:09 -0000 Received: (qmail 11425 invoked by uid 1000); 16 May 2003 13:34:08 -0000 Date: Fri, 16 May 2003 15:34:08 +0200 To: Holger Burbach Cc: PHP Internals Message-ID: <20030516133408.GA11228@lxr> References: <200305161525.04359.holger.burbach@gonicus.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200305161525.04359.holger.burbach@gonicus.de> User-Agent: Mutt/1.5.3i Subject: Re: [PHP-DEV] PECL Package Proposal: kadm5 - REPOST From: sander@php.net (Sander Roobol) On Fri, May 16, 2003 at 03:25:04PM +0200, Holger Burbach wrote: > There is a new release of kadm5 with some minor changes. The sources can > be found at: > > ftp://oss.gonicus.de/pub/php-kadm5/php-kadm5-0.2.2/ Looks fine, BUT (Derick, still reading? :) * There are some comments from the ext/skel that should (IMO) be removed. Stuff like 'If you have INI entries ...' * The PHP_FUNCTION()s don't have protos. Please add them. * There are some whitespace inconsistancies here and there. Apart from that +1. Sander