Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15636 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 45592 invoked by uid 1010); 27 Mar 2005 12:57:40 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 45577 invoked from network); 27 Mar 2005 12:57:40 -0000 Received: from unknown (HELO zend.com) (127.0.0.1) by localhost with SMTP; 27 Mar 2005 12:57:40 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:43132] helo=mail.zend.com) by pb1.pair.com (ecelerity HEAD r(5268)) with SMTP id E9/46-08304-3CDA6424 for ; Sun, 27 Mar 2005 07:57:40 -0500 Received: (qmail 14422 invoked from network); 27 Mar 2005 12:57:36 -0000 Received: from internal.zend.office (HELO localhost) (10.1.1.1) by internal.zend.office with SMTP; 27 Mar 2005 12:57:36 -0000 Date: Sun, 27 Mar 2005 16:57:36 +0400 To: Zeev Suraski Cc: kingwez@gmail.com, internals@lists.php.net, ilia@php.net Message-ID: <20050327165736.0e5711f1.antony@zend.com> In-Reply-To: <5.1.0.14.2.20050327140030.060cae60@localhost> References: <20050326130556.068b80de.antony@zend.com> <20050326130556.068b80de.antony@zend.com> <5.1.0.14.2.20050327140030.060cae60@localhost> X-Mailer: Sylpheed version 1.9.6 (GTK+ 2.4.9; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Sun__27_Mar_2005_16_57_36_+0400_InSansKCrWhTlKuy" Subject: Re: [PHP-DEV] Two minor issues in 5.0.4 From: antony@zend.com (Antony Dovgal) --Multipart=_Sun__27_Mar_2005_16_57_36_+0400_InSansKCrWhTlKuy Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 27 Mar 2005 14:51:09 +0200 Zeev Suraski wrote: > How are you planning to change it? See the diffs attached. -- Wbr, Antony Dovgal aka tony2001 antony@zend.com --Multipart=_Sun__27_Mar_2005_16_57_36_+0400_InSansKCrWhTlKuy Content-Type: text/plain; name="streams.diff.txt" Content-Disposition: attachment; filename="streams.diff.txt" Content-Transfer-Encoding: 7bit Index: main/php_streams.h =================================================================== RCS file: /repository/php-src/main/php_streams.h,v retrieving revision 1.95.2.2 diff -u -p -d -r1.95.2.2 php_streams.h --- main/php_streams.h 22 Feb 2005 00:24:50 -0000 1.95.2.2 +++ main/php_streams.h 27 Mar 2005 12:55:37 -0000 @@ -413,7 +413,7 @@ END_EXTERN_C() * Uses mmap if the src is a plain file and at offset 0 * To ensure we don't take up too much memory when reading large files, set the default mmap length * at this many bytes */ -#define PHP_STREAM_COPY_ALL 2000000 +#define PHP_STREAM_COPY_ALL ((size_t)-1) BEGIN_EXTERN_C() PHPAPI size_t _php_stream_copy_to_stream(php_stream *src, php_stream *dest, size_t maxlen STREAMS_DC TSRMLS_DC); --Multipart=_Sun__27_Mar_2005_16_57_36_+0400_InSansKCrWhTlKuy Content-Type: text/plain; name="url.diff.txt" Content-Disposition: attachment; filename="url.diff.txt" Content-Transfer-Encoding: 7bit Index: ext/standard/url_scanner_ex.re =================================================================== RCS file: /repository/php-src/ext/standard/url_scanner_ex.re,v retrieving revision 1.72.2.1 diff -u -p -d -r1.72.2.1 url_scanner_ex.re --- ext/standard/url_scanner_ex.re 23 Jul 2004 02:05:51 -0000 1.72.2.1 +++ ext/standard/url_scanner_ex.re 27 Mar 2005 12:55:56 -0000 @@ -488,7 +488,7 @@ int php_url_scanner_reset_vars(TSRMLS_D) BG(url_adapt_state_ex).form_app.len = 0; BG(url_adapt_state_ex).url_app.len = 0; - return FAILURE; + return SUCCESS; } PHP_MINIT_FUNCTION(url_scanner) Index: ext/standard/url_scanner_ex.c =================================================================== RCS file: /repository/php-src/ext/standard/url_scanner_ex.c,v retrieving revision 1.86.2.1 diff -u -p -d -r1.86.2.1 url_scanner_ex.c --- ext/standard/url_scanner_ex.c 23 Jul 2004 02:05:51 -0000 1.86.2.1 +++ ext/standard/url_scanner_ex.c 27 Mar 2005 12:55:56 -0000 @@ -1059,7 +1059,7 @@ int php_url_scanner_reset_vars(TSRMLS_D) BG(url_adapt_state_ex).form_app.len = 0; BG(url_adapt_state_ex).url_app.len = 0; - return FAILURE; + return SUCCESS; } PHP_MINIT_FUNCTION(url_scanner) --Multipart=_Sun__27_Mar_2005_16_57_36_+0400_InSansKCrWhTlKuy--