Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15635 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40887 invoked by uid 1010); 27 Mar 2005 12:51:55 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 40872 invoked from network); 27 Mar 2005 12:51:55 -0000 Received: from unknown (HELO zend.com) (127.0.0.1) by localhost with SMTP; 27 Mar 2005 12:51:55 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:43011] helo=mail.zend.com) by pb1.pair.com (ecelerity HEAD r(5268)) with SMTP id 91/16-08304-A6CA6424 for ; Sun, 27 Mar 2005 07:51:55 -0500 Received: (qmail 13552 invoked from network); 27 Mar 2005 12:51:51 -0000 Received: from localhost (HELO zeev-notebook.zend.com) (127.0.0.1) by localhost with SMTP; 27 Mar 2005 12:51:51 -0000 Message-ID: <5.1.0.14.2.20050327140030.060cae60@localhost> X-Sender: zeev@localhost X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Sun, 27 Mar 2005 14:51:09 +0200 To: Wez Furlong ,Antony Dovgal , Cc: internals@lists.php.net,ilia@php.net In-Reply-To: <20050327155556.35fe054a.antony@zend.com> References: <20050326130556.068b80de.antony@zend.com> <20050326130556.068b80de.antony@zend.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] Two minor issues in 5.0.4 From: zeev@zend.com (Zeev Suraski) At 13:55 27/03/2005, Antony Dovgal wrote: >On Sat, 26 Mar 2005 13:05:56 +0300 >Antony Dovgal wrote: > > > Hi all! > > > > I'd like to fix two minor issues before releasing 5.0.4. > > > > These issues are: > > 1) mmap'ed files are bound to 2M. > > In HEAD PHP_STREAM_COPY_ALL is ((size_t)-1), but for some reasons in > 5.0.4 it is set to 2000000. > > That causes readfile() to read only 2Mb and stop (which is rather > frustrating). > > See main/php_streams.h Wez - is that safe to MFH it to the 5_0 branch (http://www.mail-archive.com/php-cvs@lists.php.net/msg15050.html)? > > 2) output_reset_rewrite_vars() *always* returns false. > > See php_url_scanner_reset_var() in ext/standard/url_scanner_ex.re, > > IMO it's just a silly typo, but this routine returns FAILURE in any case. > > The very same problem actually exists in all other branches too > > > > If nobody objects, I'll fix both issues in the evening. How are you planning to change it? Zeev