Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15634 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 4005 invoked by uid 1010); 27 Mar 2005 11:56:01 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 3990 invoked from network); 27 Mar 2005 11:56:01 -0000 Received: from unknown (HELO zend.com) (127.0.0.1) by localhost with SMTP; 27 Mar 2005 11:56:01 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:41264] helo=mail.zend.com) by pb1.pair.com (ecelerity HEAD r(5268)) with SMTP id 9E/65-08304-F4F96424 for ; Sun, 27 Mar 2005 06:56:00 -0500 Received: (qmail 29268 invoked from network); 27 Mar 2005 11:55:56 -0000 Received: from internal.zend.office (HELO localhost) (10.1.1.1) by internal.zend.office with SMTP; 27 Mar 2005 11:55:56 -0000 Date: Sun, 27 Mar 2005 15:55:56 +0400 To: Antony Dovgal Cc: internals@lists.php.net, ilia@php.net, zeev@zend.com Message-ID: <20050327155556.35fe054a.antony@zend.com> In-Reply-To: <20050326130556.068b80de.antony@zend.com> References: <20050326130556.068b80de.antony@zend.com> X-Mailer: Sylpheed version 1.9.6 (GTK+ 2.4.9; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Two minor issues in 5.0.4 From: antony@zend.com (Antony Dovgal) On Sat, 26 Mar 2005 13:05:56 +0300 Antony Dovgal wrote: > Hi all! > > I'd like to fix two minor issues before releasing 5.0.4. > > These issues are: > 1) mmap'ed files are bound to 2M. > In HEAD PHP_STREAM_COPY_ALL is ((size_t)-1), but for some reasons in 5.0.4 it is set to 2000000. > That causes readfile() to read only 2Mb and stop (which is rather frustrating). > See main/php_streams.h > > 2) output_reset_rewrite_vars() *always* returns false. > See php_url_scanner_reset_var() in ext/standard/url_scanner_ex.re, > IMO it's just a silly typo, but this routine returns FAILURE in any case. > The very same problem actually exists in all other branches too > > If nobody objects, I'll fix both issues in the evening. Ilia, Zeev, any objections? -- Wbr, Antony Dovgal aka tony2001 antony@zend.com