Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15629
Return-Path: <pollita@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 83642 invoked by uid 1010); 27 Mar 2005 05:54:51 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 83627 invoked by uid 1007); 27 Mar 2005 05:54:51 -0000
Message-ID: <20050327055451.83626.qmail@lists.php.net>
To: internals@lists.php.net
References: <002c01c53244$5a47d870$0b00000a@blaster>
Date: Sat, 26 Mar 2005 21:54:52 -0800
Lines: 24
X-Priority: 3
X-MSMail-Priority: Normal
X-Newsreader: Microsoft Outlook Express 6.00.2900.2180
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180
X-RFC2646: Format=Flowed; Original
X-Posted-By: 69.12.155.129
Subject: Re: Showstopper? copy() broken for urls and on windows
From: pollita@php.net ("Sara Golemon")

> Patch to fix  #32160 (file truncation in copy() when source & destination
> are
> the same)
>
> http://viewcvs.php.net/viewcvs.cgi/php-src/ext/standard/file.c.diff?r1=1.398&r2=1.399
>
> broke copy() on windows alltogether it seems. It also broke copy($url,
> $local_file) on other platforms since it tries to stat() urls.
>
> I suggest that we remove this fix and release 4.3.11 and 5.0.4 without it. 
> I
> do not think that this change requires additional RC.
>
Holy crap!

I mean, um... yes, nix that.  Or if the stat approach must be used, use 
php_stream_url_stat() instead and only `return ret;` IF both stats succeed 
AND their inodes are non-zero (wrappers which do not support inode values 
but do support some statting are expected to leave these values as 0) AND 
their inodes are identical.

-Sara