Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15626 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86940 invoked by uid 1010); 26 Mar 2005 20:40:14 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 86924 invoked from network); 26 Mar 2005 20:40:14 -0000 Received: from unknown (HELO emini.dk) (127.0.0.1) by localhost with SMTP; 26 Mar 2005 20:40:14 -0000 X-Host-Fingerprint: 192.38.9.232 gw2.emini.dk Linux 2.4/2.6 Received: from ([192.38.9.232:14728] helo=gw2.emini.dk) by pb1.pair.com (ecelerity HEAD r(5268)) with SMTP id 27/2B-02544-DA8C5424 for ; Sat, 26 Mar 2005 15:40:14 -0500 Received: from blaster (gw1.emini.dk [212.242.124.121]) by gw2.emini.dk (Postfix) with ESMTP id BFEF754D07; Sat, 26 Mar 2005 21:40:09 +0100 (CET) Message-ID: <002c01c53244$5a47d870$0b00000a@blaster> To: , "Ilia Alshanetsky" Cc: "PHP Internals" Date: Sat, 26 Mar 2005 21:42:40 +0100 Organization: Emini ApS MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.3790.224 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.224 Subject: Showstopper? copy() broken for urls and on windows From: edink@emini.dk ("Edin Kadribasic") Hi, Patch to fix #32160 (file truncation in copy() when source & destination are the same) http://viewcvs.php.net/viewcvs.cgi/php-src/ext/standard/file.c.diff?r1=1.398&r2=1.399 broke copy() on windows alltogether it seems. It also broke copy($url, $local_file) on other platforms since it tries to stat() urls. I suggest that we remove this fix and release 4.3.11 and 5.0.4 without it. I do not think that this change requires additional RC. Edin