Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15594
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
To: internals@lists.php.net
Date: Fri, 25 Mar 2005 12:55:30 +0100
Lines: 51
Message-ID: <d20u73$1ar$1@sea.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317)
Sender: news <news@sea.gmane.org>
Subject: pdo: binding variables supplied to execute() is NotVeryUseful(tm)...
From: thies@thieso.net ("Thies C. Arntzen")

hi,

pdo hat it's own query-parser, named variables are prefixed with a 
colon... so far - so nice...

i have a function called insert which is called like this:

$db->insert('some_table', array('name' => $name, 'age' => $age));

it's implemented like this:

function insert($table, $values) {
     $column_names = array_keys($values);
     $col_list = implode(', ', $column_names);
     $bind_list = implode(', :', $column_names);

     $sql = "insert into $table ($col_list) values ($bind_list)";
	
     $stmt = $this->prepareStatement($sql);

     // works:
     // this is how it has to be done..
     //
     foreach ($values as $col => $val) {
         $stmt->bindParam(":$col", $values[ $col ]);
     }
     $stmt->execute();

     // doesn't work
     // and this is how i would like it instead
     //
     # $stmt->execute($values);
}


and this is 'cause pdo _expects_ the user to prefix the bound variables 
with a colon. grr...

ppls, lets change it before it's too late. this "tiny bit" makes binding 
harder than it should be, and we all know and understand that all user 
of php should use bound variables all the time!

suggestion: auto-trim a leading colon from the internal binding tables. 
that way "oldish" code would not break...


re, thies

PS: looking into that right now - hopefully "patch follows";-)