Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15582 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 76321 invoked by uid 1010); 24 Mar 2005 15:38:23 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 76215 invoked from network); 24 Mar 2005 15:38:23 -0000 Received: from unknown (HELO marcus-boerger.de) (127.0.0.1) by localhost with SMTP; 24 Mar 2005 15:38:23 -0000 X-Host-Fingerprint: 81.169.182.136 h59705.serverkompetenz.net Linux 2.4/2.6 Received: from ([81.169.182.136:50794] helo=strato.aixcept.de) by pb1.pair.com (ecelerity HEAD r(5268)) with SMTP id 61/46-02157-EEED2424 for ; Thu, 24 Mar 2005 10:38:23 -0500 Received: from [192.168.1.3] (dsl-082-083-253-094.arcor-ip.net [82.83.253.94]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id 18ACA35C1B7; Thu, 24 Mar 2005 16:43:08 +0100 (CET) Date: Thu, 24 Mar 2005 16:38:35 +0100 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <1099660230.20050324163835@marcus-boerger.de> To: Jesse Binam Cc: internals@lists.php.net In-Reply-To: <65530d4805032406443f9d0fb@mail.gmail.com> References: <65530d4805032406443f9d0fb@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] zend_list_delete From: mail@marcus-boerger.de (Marcus Boerger) Hello Jesse, Thursday, March 24, 2005, 3:44:18 PM, you wrote: > does zend_list_delete free the resource making lines 2 & 3 redundent? > 1 ZEND_FETCH_RESOURCE(ftp, ftpbuf_t*, &z_ftp, -1, le_ftpbuf_name, le_ftpbuf); > 2 zend_list_delete(Z_LVAL_P(z_ftp)) > 3 efree(ftp) Line three is wrong it should be zval_ptr_dtor(&z_ftp) and no, it doesn't make the efree()/zval_ptr_dtor() redundant. It only frees the members but doesn't care for the zval. -- Best regards, Marcus mailto:mail@marcus-boerger.de