Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15526
Return-Path: <valyala@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 71483 invoked by uid 1010); 21 Mar 2005 20:45:32 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 71468 invoked by uid 1007); 21 Mar 2005 20:45:32 -0000
Message-ID: <20050321204531.71467.qmail@lists.php.net>
To: internals@lists.php.net
References: <opsnujjoezlf5mcf@valyala> <20050318210856.56198.qmail@lists.php.net>
Date: Mon, 21 Mar 2005 22:50:58 +0300
Lines: 28
X-Priority: 3
X-MSMail-Priority: Normal
X-Newsreader: Microsoft Outlook Express 6.00.2800.1437
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1441
X-Posted-By: 207.226.20.21
Subject: Re: implode() speedup in PHP4
From: valyala@gmail.com ("Alexander Valyalkin")

> After applying the change to ext/standard/string.c in PHP4 the following
> Test failed:
> Bug #22224 (implode changes object references in array)
> [ext/standard/tests/strings/bug22224.phpt]
>
> Regards,
>   Christian Stadler

I understood my fault. I didn't notice condition
if (!(*ppzv)->is_ref) { }
in convert_to_ex_master() macro.

But compare execution time of the following test on PHP4 & PHP5:
<?
function getmicrotime()
{
    list($usec, $sec) = explode(" ", microtime());
    return ((float)$usec + (float)$sec);
}
$t = getmicrotime();
$s = str_repeat('a', 1 << 24);
$a = implode(",", array($s, $s));
echo getmicrotime() - $t;
?>

I think, it will be good idea to fix such time wasting in PHP4.