Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15523 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 1818 invoked by uid 1010); 21 Mar 2005 16:22:28 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 1803 invoked from network); 21 Mar 2005 16:22:27 -0000 Received: from unknown (HELO zend.com) (127.0.0.1) by localhost with SMTP; 21 Mar 2005 16:22:27 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:38951] helo=mail.zend.com) by pb1.pair.com (ecelerity HEAD r(5268)) with SMTP id D3/9A-57575-2C4FE324 for ; Mon, 21 Mar 2005 11:22:27 -0500 Received: (qmail 32468 invoked from network); 21 Mar 2005 16:22:20 -0000 Received: from localhost (HELO ANDI-NOTEBOOK.zend.com) (127.0.0.1) by localhost with SMTP; 21 Mar 2005 16:22:20 -0000 Message-ID: <5.1.0.14.2.20050321082210.02c5fa20@localhost> X-Sender: andi@localhost X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Mon, 21 Mar 2005 08:22:13 -0800 To: Joe Orton ,internals@lists.php.net In-Reply-To: <20050321093641.GA2443@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] [PATCH] 5.0/Zend memset fix From: andi@zend.com (Andi Gutmans) References: <20050321093641.GA2443@redhat.com> Commited. Thanks. At 09:36 AM 3/21/2005 +0000, Joe Orton wrote: >Found by Dave Jones grepping for memset(,,0)... only applies to the 5.0 >branch: either correct it as below or remove the line completely? > >Index: zend_execute.c >=================================================================== >RCS file: /repository/ZendEngine2/zend_execute.c,v >retrieving revision 1.652.2.21 >diff -u -r1.652.2.21 zend_execute.c >--- zend_execute.c 10 Mar 2005 02:34:11 -0000 1.652.2.21 >+++ zend_execute.c 21 Mar 2005 09:32:39 -0000 >@@ -4316,7 +4316,7 @@ > > void zend_init_opcodes_handlers() > { >- memset(zend_opcode_handlers, sizeof(zend_opcode_handlers), 0); >+ memset(zend_opcode_handlers, 0, sizeof(zend_opcode_handlers)); > zend_opcode_handlers[ZEND_NOP] = zend_nop_handler; > zend_opcode_handlers[ZEND_ADD] = zend_add_handler; > zend_opcode_handlers[ZEND_SUB] = zend_sub_handler; > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php