Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15521 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 54208 invoked by uid 1010); 21 Mar 2005 09:36:46 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 54193 invoked from network); 21 Mar 2005 09:36:46 -0000 Received: from unknown (HELO redhat.com) (127.0.0.1) by localhost with SMTP; 21 Mar 2005 09:36:46 -0000 X-Host-Fingerprint: 66.187.233.31 mx1.redhat.com Linux 2.4/2.6 Received: from ([66.187.233.31:33958] helo=mx1.redhat.com) by pb1.pair.com (ecelerity HEAD r(5268)) with SMTP id 1D/91-06002-DA59E324 for ; Mon, 21 Mar 2005 04:36:45 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j2L9ahmu006176 for ; Mon, 21 Mar 2005 04:36:43 -0500 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j2L9agY28450 for ; Mon, 21 Mar 2005 04:36:42 -0500 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.13.1/8.12.7) with ESMTP id j2L9afj7002530 for ; Mon, 21 Mar 2005 09:36:41 GMT Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.13.1/8.12.10/Submit) id j2L9afRk002529 for internals@lists.php.net; Mon, 21 Mar 2005 09:36:41 GMT Date: Mon, 21 Mar 2005 09:36:41 +0000 To: internals@lists.php.net Message-ID: <20050321093641.GA2443@redhat.com> Mail-Followup-To: internals@lists.php.net Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.4.1i Subject: [PATCH] 5.0/Zend memset fix From: jorton@redhat.com (Joe Orton) Found by Dave Jones grepping for memset(,,0)... only applies to the 5.0 branch: either correct it as below or remove the line completely? Index: zend_execute.c =================================================================== RCS file: /repository/ZendEngine2/zend_execute.c,v retrieving revision 1.652.2.21 diff -u -r1.652.2.21 zend_execute.c --- zend_execute.c 10 Mar 2005 02:34:11 -0000 1.652.2.21 +++ zend_execute.c 21 Mar 2005 09:32:39 -0000 @@ -4316,7 +4316,7 @@ void zend_init_opcodes_handlers() { - memset(zend_opcode_handlers, sizeof(zend_opcode_handlers), 0); + memset(zend_opcode_handlers, 0, sizeof(zend_opcode_handlers)); zend_opcode_handlers[ZEND_NOP] = zend_nop_handler; zend_opcode_handlers[ZEND_ADD] = zend_add_handler; zend_opcode_handlers[ZEND_SUB] = zend_sub_handler;