Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15492
Return-Path: <moriyoshi@at.wakwak.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 60077 invoked by uid 1010); 18 Mar 2005 21:13:15 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 60062 invoked from network); 18 Mar 2005 21:13:15 -0000
Received: from unknown (HELO pb1.pair.com) (127.0.0.1)
  by localhost with SMTP; 18 Mar 2005 21:13:15 -0000
X-Host-Fingerprint: 211.9.231.193 mgkyb2.nw.wakwak.com FreeBSD 4.6-4.9
Received: from ([211.9.231.193:4613] helo=mgkyb2.nw.wakwak.com)
	by pb1.pair.com (ecelerity HEAD r(5268)) with SMTP
	id C5/C6-32829-9644B324 for <internals@lists.php.net>; Fri, 18 Mar 2005 16:13:14 -0500
Received: from vckyb2.nw.wakwak.com (vckyb2.nw.wakwak.com [211.9.230.145])
	by mgkyb2.nw.wakwak.com (8.13.3/8.13.3/2005-01-27) with SMTP id j2ILD682021202;
	Sat, 19 Mar 2005 06:13:06 +0900 (JST)
	(envelope-from moriyoshi@at.wakwak.com)
Received: from at.wakwak.com (at.wakwak.com [211.9.230.135])
	by vckyb2.nw.wakwak.com (Postfix) with ESMTP
	id 32FFB40003; Sat, 19 Mar 2005 06:13:06 +0900 (JST)
Received: from [192.168.0.2] (newcycle.as.wakwak.ne.jp [218.225.209.145])
	(pbs=u6t9ov)
	by at.wakwak.com (8.13.3/8.13.3/2005-01-26) with ESMTP/inet id j2ILD5jn044827;
	Sat, 19 Mar 2005 06:13:06 +0900 (JST)
	(envelope-from moriyoshi@at.wakwak.com)
In-Reply-To: <opsnujjoezlf5mcf@valyala>
References: <opsnujjoezlf5mcf@valyala>
Mime-Version: 1.0 (Apple Message framework v619.2)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-ID: <a6e36d304e6592e528386d55ee189aec@at.wakwak.com>
Content-Transfer-Encoding: 7bit
Cc: internals@lists.php.net
Date: Sat, 19 Mar 2005 06:12:16 +0900
To: "Alexander Valyalkin" <valyala@gmail.com>
X-Mailer: Apple Mail (2.619.2)
Subject: Re: [PHP-DEV] implode() speedup in PHP4
From: moriyoshi@at.wakwak.com (Moriyoshi Koizumi)


On 2005/03/19, at 3:41, Alexander Valyalkin wrote:

>
> I've posted patch last summer 
> http://www.zend.com/zend/week/pat/pat5.txt
> which imporves performance of implode() function in PHP4, but nobody 
> doesn't
> commit it yet. Can anybody explain the reason?

Because convert_to_string_ex() modifies the content of every element
that is not of string type.

<?php
$arrays = array(array(), array(), array());
var_dump(implode('', $arrays));
var_dump($arrays);
?>

We already have an optimisation in the 5.x branches.
I think it is appliable to the 4.3 branch.

Moriyoshi