Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15476 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 57860 invoked by uid 1010); 17 Mar 2005 12:37:33 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 57835 invoked from network); 17 Mar 2005 12:37:33 -0000 Received: from unknown (HELO pb1.pair.com) (127.0.0.1) by localhost with SMTP; 17 Mar 2005 12:37:33 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:57989] helo=mail.zend.com) by pb1.pair.com (ecelerity HEAD r(5268)) with SMTP id 22/8A-09621-B0A79324 for ; Thu, 17 Mar 2005 07:37:32 -0500 Received: (qmail 31342 invoked from network); 17 Mar 2005 12:30:47 -0000 Received: from localhost (HELO zeev-notebook.zend.com) (127.0.0.1) by localhost with SMTP; 17 Mar 2005 12:30:47 -0000 Message-ID: <5.1.0.14.2.20050317133326.06c9cd10@localhost> X-Sender: zeev@localhost X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Thu, 17 Mar 2005 14:30:46 +0200 To: Christopher Kings-Lynne Cc: php-dev ,helly@php.net,yohgaki@php.net In-Reply-To: <4237C24C.7000607@familyhealth.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] Major upgrade to ext/pgsql From: zeev@zend.com (Zeev Suraski) References: <4237C24C.7000607@familyhealth.com.au> At 07:21 16/03/2005, Christopher Kings-Lynne wrote: >Hi, > >Attached is a patch that brings PostgreSQL support in PHP out of the stone >age! The patch looks great. Do you have a CVS account? If not, apply for one and I'll set you up with access to ext/pgsql so that you can commit and maintain that patch. >Should pg_query_params instead be folded into pg_query, with an optional >3rd parameter which would be the parameter array? Would this then be >difficult for clients to detect if the 3rd parameter is available to them? As you noticed, right now it's a problem. Lately I've been thinking about preparing infrastructure that will allow you to specify the mandatory/optional arguments in order (as you do today), but also an extra resource-type argument, that can appear anywhere in the argument list, and will be updated if it's found or NULL'd if it isn't. This will allow the concept of 'default resource' to work better with other optional (or newly introduced) arguments. I have to think about it some more and see if it's feasible. In the meantime, you should probably keep pg_query_params(). Zeev