Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15389 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 96729 invoked by uid 1010); 11 Mar 2005 22:30:34 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 96707 invoked from network); 11 Mar 2005 22:30:34 -0000 Received: from unknown (HELO prohost.org) (127.0.0.1) by localhost with SMTP; 11 Mar 2005 22:30:34 -0000 X-Host-Fingerprint: 70.85.46.36 unknown Received: from ([70.85.46.36:48369] helo=prohost.org) by pb1.pair.com (ecelerity HEAD r(5124)) with SMTP id 33/1A-31540-90C12324 for ; Fri, 11 Mar 2005 17:30:34 -0500 Received: (qmail 3456 invoked from network); 11 Mar 2005 22:30:31 -0000 Received: from cpe00095beeab35-cm000f9f7d6664.cpe.net.cable.rogers.com (HELO ?192.168.1.101?) (69.196.31.219) by prohost.org with SMTP; 11 Mar 2005 22:30:31 -0000 Message-ID: <42321C06.3080903@prohost.org> Date: Fri, 11 Mar 2005 17:30:30 -0500 User-Agent: Mozilla Thunderbird 1.0 - [MOOX M3] (Windows/20041208) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Sara Golemon CC: internals@lists.php.net References: <4231F330.6000705@prohost.org> <4e89b426050311134633b22b@mail.gmail.com> <4232163C.1000906@prohost.org> <20050311221141.70135.qmail@lists.php.net> In-Reply-To: <20050311221141.70135.qmail@lists.php.net> X-Enigmail-Version: 0.89.5.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] HALT Patch From: ilia@prohost.org (Ilia Alshanetsky) Sara Golemon wrote: > Just a nudge about this code approach. > #1 It doesn't detect EOF Well, if you encounter EOF before the HALT tag, it means as a developer of the script you are trying to break your own code ;-) > #2 It forgets about the newline returned by fgets( True, I suppose strncmp could be used here, since newline is not always constant. > #3 It doesn't allow the HALT; to float within a line between other content > (not that you'd do that anyway but... Going back to #1 ;-). Ilia