Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15386
Return-Path: <pollita@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 70151 invoked by uid 1010); 11 Mar 2005 22:11:41 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 70136 invoked by uid 1007); 11 Mar 2005 22:11:41 -0000
Message-ID: <20050311221141.70135.qmail@lists.php.net>
To: internals@lists.php.net
References: <4231F330.6000705@prohost.org> <4e89b426050311134633b22b@mail.gmail.com> <4232163C.1000906@prohost.org>
Date: Fri, 11 Mar 2005 14:11:41 -0800
Lines: 12
X-Priority: 3
X-MSMail-Priority: Normal
X-Newsreader: Microsoft Outlook Express 6.00.2900.2180
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180
X-RFC2646: Format=Flowed; Original
X-Posted-By: 64.142.6.231
Subject: Re: [PHP-DEV] HALT Patch
From: pollita@php.net ("Sara Golemon")

> 1) while (fgets($fp) != '<?php __HALT_PHP_PARSER__; ?>'));
>
Just a nudge about this code approach.
  #1 It doesn't detect EOF
  #2 It forgets about the newline returned by fgets()
  #3 It doesn't allow the HALT; to float within a line between other content 
(not that you'd do that anyway but...

while (($tmp = fgets($fp)) && (strpos($tmp, '<?php __HALT_PHP_PARSER__; ?>') 
!== false));