Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15340 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 58005 invoked by uid 1010); 10 Mar 2005 10:17:17 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 57990 invoked from network); 10 Mar 2005 10:17:17 -0000 Received: from unknown (HELO whitehouseit.com) (127.0.0.1) by localhost with SMTP; 10 Mar 2005 10:17:17 -0000 X-Host-Fingerprint: 66.187.233.31 mx1.redhat.com Linux 2.4/2.6 Received: from ([66.187.233.31:48069] helo=mx1.redhat.com) by pb1.pair.com (ecelerity HEAD r(5124)) with SMTP id DC/DE-53294-DAE10324 for ; Thu, 10 Mar 2005 05:17:17 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j2AAHEjS021835 for ; Thu, 10 Mar 2005 05:17:14 -0500 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j2AAHDn18255 for ; Thu, 10 Mar 2005 05:17:14 -0500 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.13.1/8.12.7) with ESMTP id j2AAHCOh006999 for ; Thu, 10 Mar 2005 10:17:13 GMT Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.13.1/8.12.10/Submit) id j2AAHCw9006998 for internals@lists.php.net; Thu, 10 Mar 2005 10:17:12 GMT Date: Thu, 10 Mar 2005 10:17:12 +0000 To: internals@lists.php.net Message-ID: <20050310101712.GA6960@redhat.com> Mail-Followup-To: internals@lists.php.net Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.4.1i Subject: [PATCH] exif warning fix? From: jorton@redhat.com (Joe Orton) Testing "length >= LONG_MAX" where length is an int is always false, and gcc gives a warning for it. Perhaps something like this was intended? Index: ext/exif/exif.c =================================================================== RCS file: /repository/php-src/ext/exif/exif.c,v retrieving revision 1.170 diff -u -r1.170 exif.c --- ext/exif/exif.c 2 Mar 2005 18:21:45 -0000 1.170 +++ ext/exif/exif.c 10 Mar 2005 10:15:31 -0000 @@ -1557,7 +1557,7 @@ image_info_data *info_data; image_info_data *list; - if (length >= LONG_MAX) { + if ((unsigned int)length >= INT_MAX) { return; }