Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15328 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 77708 invoked by uid 1010); 9 Mar 2005 16:14:25 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 77687 invoked from network); 9 Mar 2005 16:14:25 -0000 Received: from unknown (HELO pb1.pair.com) (127.0.0.1) by localhost with SMTP; 9 Mar 2005 16:14:25 -0000 X-Host-Fingerprint: 64.233.184.207 wproxy.gmail.com Linux 2.4/2.6 Received: from ([64.233.184.207:22706] helo=wproxy.gmail.com) by pb1.pair.com (ecelerity HEAD r(5124)) with SMTP id 5A/6C-53294-1E02F224 for ; Wed, 09 Mar 2005 11:14:25 -0500 Received: by wproxy.gmail.com with SMTP id 37so218935wra for ; Wed, 09 Mar 2005 08:14:22 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=FiX7jz5wjkcSiLKhDn62vXQFVEOcyOsftOmw8HDLyqoDY3j7wWkFoJtjUsPx5tELrcsiHQkRFQOXM8a7h+VKnxM+9xlXr75/i7yZgBMBHtfqwVt5SY1fFrFAZ6SoFaCVlz+YwZ0Ahdb5yKHkGqQ63NjmZzc1yoIBqLUA+/Xaz5M= Received: by 10.54.4.24 with SMTP id 24mr761417wrd; Wed, 09 Mar 2005 08:14:22 -0800 (PST) Received: by 10.54.44.57 with HTTP; Wed, 9 Mar 2005 08:14:22 -0800 (PST) Message-ID: <4e89b42605030908146b8d99f3@mail.gmail.com> Date: Wed, 9 Mar 2005 11:14:22 -0500 Reply-To: Wez Furlong To: Stanislav Malyshev Cc: PHP Development In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <4e89b4260503090718503f9a5@mail.gmail.com> <4e89b42605030907315a85ce74@mail.gmail.com> <4e89b426050309075047ce556c@mail.gmail.com> Subject: Re: [PHP-DEV] zend_stream_fixup From: kingwez@gmail.com (Wez Furlong) Yes, you missed that a stream can be any stream from PHP land. Which code in the engine does more than read/close? --Wez. On Wed, 9 Mar 2005 18:00:11 +0200 (IST), Stanislav Malyshev wrote: > WF>>You can't rely on stat working. > > Why not? What's so special in stat that it can not work on file handle? > > And why this STREAM type at all - if the only places it is used is where > you have switch on type anyway or in zend_stream.c where you could have > the switch as well? What did you achive by this but breaking all code that > used file_handle for more that read/close? So far I see that by using > fixup and converting all FPs to STREAMs you saved one if in > zend_stream_read/zend_stream_getc and that's it. Is there anything I miss?