Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:15327 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 59862 invoked by uid 1010); 9 Mar 2005 16:00:17 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 59818 invoked from network); 9 Mar 2005 16:00:15 -0000 Received: from unknown (HELO pb1.pair.com) (127.0.0.1) by localhost with SMTP; 9 Mar 2005 16:00:15 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:48605] helo=mail.zend.com) by pb1.pair.com (ecelerity HEAD r(5124)) with SMTP id 79/BB-53294-E8D1F224 for ; Wed, 09 Mar 2005 11:00:15 -0500 Received: (qmail 11932 invoked from network); 9 Mar 2005 16:00:11 -0000 Received: from shire.zend.office (10.1.2.160) by internal.zend.office with SMTP; 9 Mar 2005 16:00:11 -0000 Date: Wed, 9 Mar 2005 18:00:11 +0200 (IST) X-X-Sender: frodo@shire.zend.office To: Wez Furlong cc: PHP Development In-Reply-To: <4e89b426050309075047ce556c@mail.gmail.com> Message-ID: References: <4e89b4260503090718503f9a5@mail.gmail.com> <4e89b42605030907315a85ce74@mail.gmail.com> <4e89b426050309075047ce556c@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] zend_stream_fixup From: stas@zend.com (Stanislav Malyshev) WF>>You can't rely on stat working. Why not? What's so special in stat that it can not work on file handle? And why this STREAM type at all - if the only places it is used is where you have switch on type anyway or in zend_stream.c where you could have the switch as well? What did you achive by this but breaking all code that used file_handle for more that read/close? So far I see that by using fixup and converting all FPs to STREAMs you saved one if in zend_stream_read/zend_stream_getc and that's it. Is there anything I miss? -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115