Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15299
Return-Path: <tularis@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 141 invoked by uid 1010); 7 Mar 2005 15:39:27 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 99918 invoked by uid 1007); 7 Mar 2005 15:39:26 -0000
Message-ID: <20050307153925.99917.qmail@lists.php.net>
To: internals@lists.php.net
Date: Mon, 07 Mar 2005 16:39:42 +0100
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050106
X-Accept-Language: en-us, en
MIME-Version: 1.0
References: <5.1.0.14.2.20050307160739.0aeb3390@localhost> <422C6670.6000300@prohost.org>
In-Reply-To: <422C6670.6000300@prohost.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Posted-By: 62.131.2.67
Subject: Re: [PHP-DEV] Problem with fix for bug #31672
From: tularis@php.net ("M. Sokolewicz")

I very much agree with this. It's very common to output JavaScript via 
PHP, and that also uses the <script></script> tags...so...

Ilia Alshanetsky wrote:
> Good point, +1 for revert.
> 
> Ilia
> 
> Zeev Suraski wrote:
> 
>> Guys,
>>
>> I'd like to revert the fix for bug #31672 ("</script> is not 
>> considered closing tag if preceded by one-line comment").  While 
>> theoretically correct, I'd rather resolve it by fixing the docs.
>>
>> The reason is simple - unlike ?> and %>, the string "</script>" is 
>> very much likely to appear inside one line comments:
>>
>> // print "<script>foo</script>";
>>
>> That suddenly fails.  That's probably the reason we didn't implement 
>> it in the first place.
>>
>> Any objections to reverting this fix?
>>
>> Zeev
>>