Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15298
Return-Path: <ilia@prohost.org>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 9856 invoked by uid 1010); 7 Mar 2005 14:34:31 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 9839 invoked from network); 7 Mar 2005 14:34:31 -0000
Received: from unknown (HELO clickidaho.com) (127.0.0.1)
  by localhost with SMTP; 7 Mar 2005 14:34:31 -0000
X-Host-Fingerprint: 70.85.46.36 unknown  
Received: from ([70.85.46.36:39252] helo=prohost.org)
	by pb1.pair.com (ecelerity HEAD r(5124)) with SMTP
	id C6/90-53294-6766C224 for <internals@lists.php.net>; Mon, 07 Mar 2005 09:34:30 -0500
Received: (qmail 2439 invoked from network); 7 Mar 2005 14:34:27 -0000
Received: from cpe00095beeab35-cm000f9f7d6664.cpe.net.cable.rogers.com (HELO ?192.168.1.101?) (69.196.31.219)
	by prohost.org with SMTP; 7 Mar 2005 14:34:27 -0000
Message-ID: <422C6670.6000300@prohost.org>
Date: Mon, 07 Mar 2005 09:34:24 -0500
User-Agent: Mozilla Thunderbird 1.0 - [MOOX M3] (Windows/20041208)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Zeev Suraski <zeev@zend.com>
CC: internals <internals@lists.php.net>
References: <5.1.0.14.2.20050307160739.0aeb3390@localhost>
In-Reply-To: <5.1.0.14.2.20050307160739.0aeb3390@localhost>
X-Enigmail-Version: 0.89.5.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Problem with fix for bug #31672
From: ilia@prohost.org (Ilia Alshanetsky)

Good point, +1 for revert.

Ilia

Zeev Suraski wrote:
> Guys,
> 
> I'd like to revert the fix for bug #31672 ("</script> is not considered 
> closing tag if preceded by one-line comment").  While theoretically 
> correct, I'd rather resolve it by fixing the docs.
> 
> The reason is simple - unlike ?> and %>, the string "</script>" is very 
> much likely to appear inside one line comments:
> 
> // print "<script>foo</script>";
> 
> That suddenly fails.  That's probably the reason we didn't implement it 
> in the first place.
> 
> Any objections to reverting this fix?
> 
> Zeev
>