Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15126
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Sun, 20 Feb 2005 19:44:14 +0300
To: Andi Gutmans <andi@zend.com>
Cc: internals@lists.php.net
Message-ID: <20050220194414.0009594e.antony@zend.com>
In-Reply-To: <5.1.0.14.2.20050217101324.01f0cdd0@localhost>
References: <20050218170535.243fee54.antony@zend.com>
	<5.1.0.14.2.20050217101324.01f0cdd0@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [patch] bug #29210 is_callable - no support for
	private and protected classes
From: antony@zend.com (Antony Dovgal)

On Thu, 17 Feb 2005 10:15:10 -0800
Andi Gutmans <andi@zend.com> wrote:

> Hi Antony,
> 
> We have too many places that manually check access restrictions at
> this point. I would like to generalize it and use that in all places,
> and make it  easier to fix problems like your patch does. Haven't had
> the time yet to  dive deeply into it and see what the right way would
> be. For example, we have similar code in zend_std_get_method().
> 
> If you have any good ideas of how we can generalize it email me.

As far as I can see zend_std_get_method() uses different semantics and
zend_is_callable() is used for more general kind of checks.

We can of course divide zend_is_callable() into several functions, but
it would just add more mess IMO.

-- 
Wbr, 
Antony Dovgal aka tony2001
antony@zend.com