Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:15098
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <5.1.0.14.2.20050217101324.01f0cdd0@localhost>
Date: Thu, 17 Feb 2005 10:15:10 -0800
To: Antony Dovgal <antony@zend.com>,php-dev <internals@lists.php.net>
In-Reply-To: <20050218170535.243fee54.antony@zend.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Subject: Re: [PHP-DEV] [patch] bug #29210 is_callable - no support for
	private and protected classes
From: andi@zend.com (Andi Gutmans)
References: <20050218170535.243fee54.antony@zend.com>

Hi Antony,

We have too many places that manually check access restrictions at this point.
I would like to generalize it and use that in all places, and make it 
easier to fix problems like your patch does. Haven't had the time yet to 
dive deeply into it and see what the right way would be.
For example, we have similar code in zend_std_get_method().

If you have any good ideas of how we can generalize it email me.

Thanks,
Andi

At 05:05 PM 2/18/2005 +0300, Antony Dovgal wrote:
>Hi all!
>
>Any volunteers to review & commit patch for #29210 ?
>
>Fresh diff against latest HEAD:
>http://tony2001.phpclub.net/dev/tmp/is_callable_HEAD.diff
>
>The patch adds support of protected/private methods to is_callable(),
>taking care of the context.
>
>test file:
>http://tony2001.phpclub.net/dev/tmp/is_callable.phpt
>
>x-posted to #php.bugs =)
>
>--
>Wbr,
>Antony Dovgal aka tony2001
>antony@zend.com
>
>--
>PHP Internals - PHP Runtime Development Mailing List
>To unsubscribe, visit: http://www.php.net/unsub.php